Issue 440563003: Fix buffer size boundary check offset by 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 440563003: Fix buffer size boundary check offset by 1 (Closed)

Created:
6 years, 4 months ago by Bo Xu

Modified:
6 years, 4 months ago

Reviewers:
jun_fang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Visibility:
Public.

More Reviews

Description

Fix buffer size boundary check offset by 1 When newPos == file size, the current block will not be read or Get. If this block is a crucial part of the document (like m_pTrailer), the program will exit with parse error and the document will not be rendered. BUG=None R=jun_fang@foxitsoftware.com Committed: https://pdfium.googlesource.com/pdfium/+/465c2a8

Patch Set 1 #

Patch Set 2 : Clean Format #

Patch Set 3 : More correction #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -25 lines)			Patch
	M	fpdfsdk/src/fpdfview.cpp	View	1 2	2 chunks	+21 lines, -25 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bo Xu

6 years, 4 months ago (2014-08-02 22:13:49 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as 465c2a8 (presubmit successful).

Expand Messages | Collapse Messages