Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 440493002: [Mac] Fix promo text background colour in the new avatar bubble. (Closed)

Created:
6 years, 4 months ago by noms (inactive)
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

[Mac] Fix promo text background colour in the new avatar bubble. Threw in a bonus refactor, because noone was passing the BackgroundHoverButton and alternate image that was different than the default image. BUG=399693 TEST=Start Chrome with --new-avatar-menu. The signin promo for local profiles should not have a white background (i.e. its background should match the bubble background) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287231

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -13 lines) Patch
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm View 7 chunks +6 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
noms (inactive)
6 years, 4 months ago (2014-08-01 23:44:37 UTC) #1
Alexei Svitkine (slow)
lgtm
6 years, 4 months ago (2014-08-02 19:01:48 UTC) #2
noms (inactive)
The CQ bit was checked by noms@chromium.org
6 years, 4 months ago (2014-08-02 21:30:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/440493002/1
6 years, 4 months ago (2014-08-02 21:31:32 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-02 22:47:18 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-02 23:09:09 UTC) #6
Message was sent while issue was closed.
Change committed as 287231

Powered by Google App Engine
This is Rietveld 408576698