Fix display:none issue for <webview>.

chrome/renderer/resources/extensions/web_view_events.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Event management for WebViewInternal.
 
 var DeclarativeWebRequestSchema =
     requireNative('schema_registry').GetSchema('declarativeWebRequest');
 var EventBindings = require('event_bindings');
 var IdGenerator = requireNative('id_generator');
 var MessagingNatives = requireNative('messaging_natives');
 var WebRequestEvent = require('webRequestInternal').WebRequestEvent;
 var WebRequestSchema =
     requireNative('schema_registry').GetSchema('webRequest');
 var WebView = require('webViewInternal').WebView;
 
 var CreateEvent = function(name) {
   var eventOpts = {supportsListeners: true, supportsFilters: true};
   return new EventBindings.Event(name, undefined, eventOpts);
 };
 
 var FrameNameChangedEvent = CreateEvent('webViewInternal.onFrameNameChanged');
+var PluginDestroyedEvent = CreateEvent('webViewInternal.onPluginDestroyed');
 var WebRequestMessageEvent = CreateEvent('webViewInternal.onMessage');
 
 // WEB_VIEW_EVENTS is a map of stable <webview> DOM event names to their
 //     associated extension event descriptor objects.
 // An event listener will be attached to the extension event |evt| specified in
 //     the descriptor.
 // |fields| specifies the public-facing fields in the DOM event that are
 //     accessible to <webview> developers.
 // |customHandler| allows a handler function to be called each time an extension
 //     event is caught by its event listener. The DOM event should be dispatched
@@ skipping 152 matching lines @@
 // Constructor.
 function WebViewEvents(webViewInternal, viewInstanceId) {
   this.webViewInternal = webViewInternal;
   this.viewInstanceId = viewInstanceId;
   this.setup();
 }
 
 // Sets up events.
 WebViewEvents.prototype.setup = function() {
   this.setupFrameNameChangedEvent();
+  this.setupPluginDestroyedEvent();
   this.setupWebRequestEvents();
   this.webViewInternal.setupExperimentalContextMenus();
 
   var events = this.getEvents();
   for (var eventName in events) {
     this.setupEvent(eventName, events[eventName]);
   }
 };
 
 WebViewEvents.prototype.setupFrameNameChangedEvent = function() {
   var self = this;
   FrameNameChangedEvent.addListener(function(e) {
     self.webViewInternal.onFrameNameChanged(e.name);
   }, {instanceId: self.viewInstanceId});
 };
 
+WebViewEvents.prototype.setupPluginDestroyedEvent = function() {
+  var self = this;
+  PluginDestroyedEvent.addListener(function(e) {
+    self.webViewInternal.onPluginDestroyed();
+  }, {instanceId: self.viewInstanceId});
+};

[Fady Samuel, 2014/08/25 18:55:34]

I'm trying to switch away from self to bind(this). Ben Kalman prefers that style
and extension_options.js has been using that style and so I think we should
adopt that style for consistency.

  PluginDestroyedEvent.addListener(function(e) {
    this.webViewInternal.onPluginDestroyed();
  }.bind(this), {instanceId: this.viewInstanceId});

[lazyboy, 2014/08/25 19:16:44]

Done.

+
 WebViewEvents.prototype.setupWebRequestEvents = function() {
   var self = this;
   var request = {};
   var createWebRequestEvent = function(webRequestEvent) {
     return function() {
       if (!self[webRequestEvent.name]) {
         self[webRequestEvent.name] =
             new WebRequestEvent(
                 'webViewInternal.' + webRequestEvent.name,
                 webRequestEvent.parameters,
@@ skipping 376 matching lines @@
   }
 };
 
 WebViewEvents.prototype.handleSizeChangedEvent = function(
     event, webViewEvent) {
   this.webViewInternal.onSizeChanged(webViewEvent);
 };
 
 exports.WebViewEvents = WebViewEvents;
 exports.CreateEvent = CreateEvent;