Fix display:none issue for <webview>.

chrome/renderer/resources/extensions/web_view.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This module implements Webview (<webview>) as a custom element that wraps a
 // BrowserPlugin object element. The object element is hidden within
 // the shadow DOM of the Webview element.
 
 var DocumentNatives = requireNative('document_natives');
 var GuestViewInternal =
@@ skipping 88 matching lines @@
   // If <object> bindings is not available, we defer attachment.
   // This state contains whether or not the attachment request was for
   // newwindow.
   this.deferredAttachState = null;
 
   // on* Event handlers.
   this.on = {};
 
   this.browserPluginNode = this.createBrowserPluginNode();
   var shadowRoot = this.webviewNode.createShadowRoot();
-  shadowRoot.appendChild(this.browserPluginNode);
+  this.partition = new Partition();
 
   this.setupWebviewNodeAttributes();
   this.setupFocusPropagation();
   this.setupWebviewNodeProperties();
 
   this.viewInstanceId = IdGenerator.GetNextId();
 
-  this.partition = new Partition();
-  this.parseAttributes();
+  new WebViewEvents(this, this.viewInstanceId);
 
-  new WebViewEvents(this, this.viewInstanceId);
+  shadowRoot.appendChild(this.browserPluginNode);
 }
 
 /**
  * @private
  */
 WebViewInternal.prototype.createBrowserPluginNode = function() {
   // We create BrowserPlugin as a custom element in order to observe changes
   // to attributes synchronously.
   var browserPluginNode = new WebViewInternal.BrowserPlugin();
   privates(browserPluginNode).internal = this;
@@ skipping 425 matching lines @@
 };
 
 /**
  * @private
  */
 WebViewInternal.prototype.handleBrowserPluginAttributeMutation =
     function(name, oldValue, newValue) {
   if (name == 'internalinstanceid' && !oldValue && !!newValue) {
     this.browserPluginNode.removeAttribute('internalinstanceid');
     this.internalInstanceId = parseInt(newValue);
-    if (this.deferredAttachState && !!this.guestInstanceId &&
-            this.guestInstanceId != 0) {
-      window.setTimeout(function() {
-        var isNewWindow = this.deferredAttachState ?
-            this.deferredAttachState.isNewWindow : false;
-        var params = this.buildAttachParams(isNewWindow);
-        guestViewInternalNatives.AttachGuest(
-            this.internalInstanceId,
-            this.guestInstanceId,
-            params);
-      }.bind(this), 0);
+    if (this.deferredAttachState) {
+      if (!!this.guestInstanceId && this.guestInstanceId != 0) {
+        window.setTimeout(function() {
+          var isNewWindow = this.deferredAttachState ?
+              this.deferredAttachState.isNewWindow : false;
+          var params = this.buildAttachParams(isNewWindow);
+          guestViewInternalNatives.AttachGuest(
+              this.internalInstanceId,
+              this.guestInstanceId,
+              params);
+        }.bind(this), 0);
+      }
+    } else {
+      this.parseAttributes();
     }
     return;
   }
 
   // This observer monitors mutations to attributes of the BrowserPlugin and
   // updates the <webview> attributes accordingly.
   // |newValue| is null if the attribute |name| has been removed.
   if (newValue != null) {
     // Update the <webview> attribute to match the BrowserPlugin attribute.
     // Note: Calling setAttribute on <webview> will trigger its mutation
@@ skipping 143 matching lines @@
 
 WebViewInternal.prototype.onFrameNameChanged = function(name) {
   this.name = name || '';
   if (this.name === '') {
     this.webviewNode.removeAttribute('name');
   } else {
     this.webviewNode.setAttribute('name', this.name);
   }
 };
 
+WebViewInternal.prototype.onPluginDestroyed = function() {
+  this.reset();

[Fady Samuel, 2014/08/23 11:06:16]

What happens if you try to set the src attribute while the guest is in a
display:none state?

[lazyboy, 2014/08/23 16:10:18]

The next setting of display = '' will navigate the webview.
There's a test for that WebViewTest.Shim_TestDisplayNoneWebviewLoad

+};
+
 WebViewInternal.prototype.dispatchEvent = function(webViewEvent) {
   return this.webviewNode.dispatchEvent(webViewEvent);
 };
 
 /**
  * Adds an 'on<event>' property on the webview, which can be used to set/unset
  * an event handler.
  */
 WebViewInternal.prototype.setupEventProperty = function(eventName) {
   var propertyName = 'on' + eventName.toLowerCase();
@@ skipping 109 matching lines @@
   return params;
 };
 
 WebViewInternal.prototype.attachWindow = function(guestInstanceId,
                                                   isNewWindow) {
   this.guestInstanceId = guestInstanceId;
   var params = this.buildAttachParams(isNewWindow);
 
   if (!this.isPluginInRenderTree()) {
     this.deferredAttachState = {isNewWindow: isNewWindow};
-    return false;
+    return true;
   }
 
   this.deferredAttachState = null;
   return guestViewInternalNatives.AttachGuest(
       this.internalInstanceId,
       this.guestInstanceId,
       params);
 };
 
 // Registers browser plugin <object> custom element.
@@ skipping 153 matching lines @@
 };
 
 /**
  * Implemented when the experimental API is available.
  * @private
  */
 WebViewInternal.prototype.setupExperimentalContextMenus = function() {};
 
 exports.WebView = WebView;
 exports.WebViewInternal = WebViewInternal;