chrome/common/content_settings_pattern_parser.h - Issue 440423003: Clean content_settings_pattern_parser.* from unnecessary dependencies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/content_settings_pattern_parser.h

Issue 440423003: Clean content_settings_pattern_parser.* from unnecessary dependencies. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: @vabr and @bauerb comments addressed Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/content_settings_pattern.cc ('K') | « chrome/common/content_settings_pattern.cc ('k') | chrome/common/content_settings_pattern_parser.cc » ('j') | components/content_settings/core/common/embedder_variables.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/content_settings_pattern_parser.h

diff --git a/chrome/common/content_settings_pattern_parser.h b/chrome/common/content_settings_pattern_parser.h

index 19f8d2710002d88379cfb22f8c5dd48724d186b6..fbd8ccc7f78265dc9890f102a0aa6ac5baf8441e 100644

--- a/chrome/common/content_settings_pattern_parser.h

+++ b/chrome/common/content_settings_pattern_parser.h

@@ -12,8 +12,6 @@

namespace content_settings {

-struct PatternParts;

class PatternParser {

public:

static void Parse(const std::string& pattern_spec,

@@ -21,21 +19,6 @@ class PatternParser {

static std::string ToString(

const ContentSettingsPattern::PatternParts& parts);

- private:

- static const char* kDomainWildcard;

- static const size_t kDomainWildcardLength;

- static const char* kSchemeWildcard;

- static const char* kHostWildcard;

- static const char* kPortWildcard;

- static const char* kPathWildcard;

- DISALLOW_COPY_AND_ASSIGN(PatternParser);

};

} // namespace content_settings