Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3894)

Unified Diff: chrome/common/content_settings_pattern_parser_unittest.cc

Issue 440423003: Clean content_settings_pattern_parser.* from unnecessary dependencies. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix CrOS tests Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/content_settings_pattern_parser_unittest.cc
diff --git a/chrome/common/content_settings_pattern_parser_unittest.cc b/chrome/common/content_settings_pattern_parser_unittest.cc
index b6d5f34f6812abef4745058e6d14b72c113c9af4..f833b13774fa63c3a34d5129343e0394bb74555c 100644
--- a/chrome/common/content_settings_pattern_parser_unittest.cc
+++ b/chrome/common/content_settings_pattern_parser_unittest.cc
@@ -2,9 +2,10 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/common/content_settings_pattern.h"
#include "chrome/common/content_settings_pattern_parser.h"
+#include "chrome/common/content_settings_component.h"
+#include "chrome/common/content_settings_pattern.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -27,6 +28,7 @@ class MockBuilder : public ContentSettingsPattern::BuilderInterface {
};
TEST(ContentSettingsPatternParserTest, ParsePatterns) {
+ InitContentSettingsComponent();
Bernhard Bauer 2014/08/18 15:55:13 I would add this to ChromeTestSuite::Initialize()
vasilii 2014/08/20 08:44:06 Done.
// Test valid patterns
::testing::StrictMock<MockBuilder> builder;
@@ -152,6 +154,7 @@ TEST(ContentSettingsPatternParserTest, ParsePatterns) {
}
TEST(ContentSettingsPatternParserTest, ParseFilePatterns) {
+ InitContentSettingsComponent();
::testing::StrictMock<MockBuilder> builder;
EXPECT_CALL(builder, WithScheme("file")).Times(1).WillOnce(
@@ -209,6 +212,7 @@ TEST(ContentSettingsPatternParserTest, ParseFilePatterns) {
}
TEST(ContentSettingsPatternParserTest, SerializePatterns) {
+ InitContentSettingsComponent();
ContentSettingsPattern::PatternParts parts;
parts.scheme = "http";
parts.host = "www.youtube.com";

Powered by Google App Engine
This is Rietveld 408576698