components/content_settings.gypi - Issue 440423003: Clean content_settings_pattern_parser.* from unnecessary dependencies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/content_settings.gypi

Issue 440423003: Clean content_settings_pattern_parser.* from unnecessary dependencies. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/content_settings_pattern_parser.cc ('K') | « chrome/renderer/content_settings_observer_browsertest.cc ('k') | components/content_settings/core/common/BUILD.gn » ('j') | components/content_settings/core/common/content_settings_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/content_settings.gypi

diff --git a/components/content_settings.gypi b/components/content_settings.gypi

index 478aa866f1a17912f27d32768b74b5c97edd4beb..517c7ac86344d485493659d85f37e9c01e1dc416 100644

--- a/components/content_settings.gypi

+++ b/components/content_settings.gypi

@@ -7,12 +7,16 @@

{

# GN version: //components/content_settings/core/common

'target_name': 'content_settings_core_common',

- 'type': 'none',

+ 'type': 'static_library',

+ 'dependencies': [

+ ],

'include_dirs': [

'..',

'sources': [

# Note: sources list duplicated in GN build.

+ 'content_settings/core/common/content_settings_client.cc',

vabr (Chromium) 2014/08/06 15:14:01 I don't think we can have the client in common. On

+ 'content_settings/core/common/content_settings_client.h',

'content_settings/core/common/content_settings_types.h',