chrome/common/content_settings_initializer.h - Issue 440423003: Clean content_settings_pattern_parser.* from unnecessary dependencies.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/content_settings_initializer.h

Issue 440423003: Clean content_settings_pattern_parser.* from unnecessary dependencies. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Reorder methods in the correct order Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_COMMON_CONTENT_SETTINGS_INITIALIZER_H_

	6 #define CHROME_COMMON_CONTENT_SETTINGS_INITIALIZER_H_

	7

	8 // Initializes the content settings component before its first usage. Should be

	9 // called once.

	10 void InitContentSettingsComponent();
	jochen (gone - plz use gerrit) 2014/09/02 08:15:50 nit. Initialize.* it's a bit generic name, howeve nit. Initialize.* it's a bit generic name, however, why not just RegisterAdditionalContentSettingURLSchemes() or similar? Why an extra file and not just inline it in the ChromeMainDelegate? If you want an extra file, why not put it in a chrome/common/content_settings/ subdir? vasilii 2014/09/02 08:50:37 Presubmit wasn't happy: Illegal include: "extensio Show quoted text On 2014/09/02 08:15:50, jochen wrote: > nit. Initialize.* > > it's a bit generic name, however, why not just > RegisterAdditionalContentSettingURLSchemes() or similar? Why an extra file and > not just inline it in the ChromeMainDelegate? > > If you want an extra file, why not put it in a chrome/common/content_settings/ > subdir? Presubmit wasn't happy: Illegal include: "extensions/common/constants.h". Rename - done. There is no chrome/common/content_settings/. All content_settings* files are in chrome/common
	11

	12 #endif // CHROME_COMMON_CONTENT_SETTINGS_INITIALIZER_H_

OLD	NEW

« chrome/browser/notifications/desktop_notification_profile_util.h ('K') | « chrome/chrome_common.gypi ('k') | chrome/common/content_settings_initializer.cc » ('j') | no next file with comments »