components/content_settings/core/common/embedder_variables.h - Issue 440423003: Clean content_settings_pattern_parser.* from unnecessary dependencies.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/content_settings/core/common/embedder_variables.h

Issue 440423003: Clean content_settings_pattern_parser.* from unnecessary dependencies. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: @vabr's comments addressed Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « components/content_settings/core/common/content_settings_types.h ('k') | components/content_settings/core/common/embedder_variables.cc » ('j') | components/content_settings/core/common/embedder_variables.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONENTS_CONTENT_SETTINGS_CORE_COMMON_EMBEDDER_VARIABLES_H_

	6 #define COMPONENTS_CONTENT_SETTINGS_CORE_COMMON_EMBEDDER_VARIABLES_H_

	7

	8 #include <string>

	9

	10 #include "base/macros.h"

	11

	12 namespace content_settings {

	13

	14 // Sets the scheme that doesn't support domain wildcard and port.

	15 // Needs to be called by the embedder before using ContentSettingsPattern.

	16 // \|scheme\| can't be NULL. The caller is responsible for its lifetime.
	vabr (Chromium) 2014/08/21 15:31:41 nit: Please join the last two sentences into: "\|sc nit: Please join the last two sentences into: "\|scheme\| can't be NULL, and the pointed string must remain alive until the Chrome terminates." if that's what you wanted to say. Currently, it's not clear what "responsible for its lifetime" means. vasilii 2014/08/22 13:02:45 Done. Show quoted text On 2014/08/21 15:31:41, vabr (Chromium) wrote: > nit: Please join the last two sentences into: > "\|scheme\| can't be NULL, and the pointed string must remain alive until the > Chrome terminates." > if that's what you wanted to say. Currently, it's not clear what "responsible > for its lifetime" means. Done.
	17 void SetNonWildcardDomainNonPortScheme(const char* scheme);

	18

	19 // Compares \|scheme\| against the scheme set by the embedder.

	20 bool IsNonWildcardDomainNonPortScheme(const std::string& scheme);

	21

	22 } // namespace content_settings

	23 #endif // COMPONENTS_CONTENT_SETTINGS_CORE_COMMON_EMBEDDER_VARIABLES_H_

OLD	NEW