Clean content_settings_pattern_parser.* from unnecessary dependencies.

components/content_settings/core/common/embedder_variables.h

+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_CONTENT_SETTINGS_CORE_COMMON_EMBEDDER_VARIABLES_H_
+#define COMPONENTS_CONTENT_SETTINGS_CORE_COMMON_EMBEDDER_VARIABLES_H_
+
+#include <string>
+
+#include "base/macros.h"
+
+namespace content_settings {
+
+// Sets the scheme that doesn't support domain wildcard and port (that is,
+// extensions::kExtensionScheme).

[Bernhard Bauer, 2014/08/18 15:55:13]

It's a bit weird to assume there is only ever going to be one scheme that
doesn't support ports. Could you make this a set?

Also, please remove the mention of kExtensionScheme from the comment. Comments
can be layering violations too :)

[vasilii, 2014/08/20 08:44:06]

We don't need this complexity now. The implementation in url_util.cc involves a
global vector, annotated memory leaks, global shutdown. 

[vabr (Chromium), 2014/08/20 09:52:22]

I support the API accepting a single scheme as not using port if it is true (see
my e-mail for file:, though), but please mention that this is for code
simplicity reasons, and if there is need to have more such schemes in the
future, there is no logical problem in adding support for that.

[vasilii, 2014/08/21 14:58:02]

Done.

+// Should be called by the embedder before using ContentSettingsPattern. The
+// caller is responsible for the lifetime of |scheme|.
+void SetNonPortScheme(const char* scheme);
+
+// Compares |scheme| against embedder's extension scheme.
+bool IsNonPortScheme(const std::string& scheme);
+
+}  // namespace content_settings
+#endif  // COMPONENTS_CONTENT_SETTINGS_CORE_COMMON_EMBEDDER_VARIABLES_H_