Issue 440383002: Enable TF for testing benchmarks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 440383002: Enable TF for testing benchmarks. (Closed)

Created:
6 years, 4 months ago by Michael Achenbach

Modified:
6 years, 4 months ago

Reviewers:
titzer, Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -4 lines)			Patch
	M	test/benchmarks/benchmarks.status	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download
	M	test/benchmarks/testcfg.py	View	1	2 chunks	+7 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

Michael Achenbach

PTAL. I'll wait with landing this until TF is ready.

6 years, 4 months ago (2014-08-06 08:34:20 UTC) #1

Michael Starzinger

LGTM. You could even add "[PASS, NO_VARIANTS]" to the status file for benchmark that fail ...

6 years, 4 months ago (2014-08-06 11:43:36 UTC) #2

Michael Achenbach

6 years, 4 months ago (2014-08-07 15:26:43 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as 22976 (presubmit successful).