Issue 440373003: Revert "Rewind additional parser state when reinterpreting arrow arguments"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 440373003: Revert "Rewind additional parser state when reinterpreting arrow arguments" (Closed)

Created:
6 years, 4 months ago by wingo

Modified:
6 years, 4 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Revert "Rewind additional parser state when reinterpreting arrow arguments" This reverts r22906. TBR=rossberg@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=22907

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -65 lines)			Patch
	M	src/parser.h	View		2 chunks	+0 lines, -18 lines	0 comments	Download
	M	src/preparser.h	View		6 chunks	+0 lines, -47 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

wingo

On 2014/08/06 09:24:04, wingo wrote: > Committed patchset #1 manually as 22907 (tree was closed). ...

6 years, 4 months ago (2014-08-06 09:25:15 UTC) #3

rossberg

6 years, 4 months ago (2014-08-06 09:54:57 UTC) #4

Message was sent while issue was closed.

On 2014/08/06 09:25:15, wingo wrote:
> On 2014/08/06 09:24:04, wingo wrote:
> > Committed patchset #1 manually as 22907 (tree was closed).
> 
> I committed this one on a closed tree as it broke the Windows build (some C++
> error).  It's not clear that the closed tree was due to my commit but it
seemed
> useful to do this revert while looking for the cause of the Linux error. 
Please
> let me know if I did the wrong thing.

Yes, the CL clearly broke the Windows build, so the revert was the right cause
of action.

Expand Messages | Collapse Messages