Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: pkg/analysis_server/lib/src/domain_completion.dart

Issue 440343003: incremental improvement to top level code completion results (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/domain_completion.dart
diff --git a/pkg/analysis_server/lib/src/domain_completion.dart b/pkg/analysis_server/lib/src/domain_completion.dart
index 0cd17da79e55dce2c758a8b2845af9069477b254..e6c9f41062248122ebb20599cebf83ade7be38a1 100644
--- a/pkg/analysis_server/lib/src/domain_completion.dart
+++ b/pkg/analysis_server/lib/src/domain_completion.dart
@@ -10,7 +10,6 @@ import 'package:analysis_server/src/protocol.dart';
import 'package:analysis_services/completion/completion_computer.dart';
import 'package:analysis_services/completion/completion_suggestion.dart';
import 'package:analysis_services/constants.dart';
-import 'package:analyzer/src/generated/source_io.dart';
/**
* Instances of the class [CompletionDomainHandler] implement a [RequestHandler]
@@ -54,9 +53,9 @@ class CompletionDomainHandler implements RequestHandler {
int offset = request.getRequiredParameter(OFFSET).asInt();
// schedule completion analysis
String completionId = (_nextCompletionId++).toString();
- Source source = server.getSource(file);
CompletionManager.create(
- source,
+ server.getAnalysisContext(file),
+ server.getSource(file),
offset,
server.searchEngine).results().listen((CompletionResult result) {
sendCompletionNotification(

Powered by Google App Engine
This is Rietveld 408576698