tools/gn/target_generator.cc - Issue 440333002: Support more configurability in GN toolchains

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/target_generator.cc

Issue 440333002: Support more configurability in GN toolchains (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: unsigned check Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/target_generator.cc

diff --git a/tools/gn/target_generator.cc b/tools/gn/target_generator.cc

index bdccf43a72459516d9fa15efddb3671e38ef06ad..657581ac0166560067eaee51ebae4f3dc68920b2 100644

--- a/tools/gn/target_generator.cc

+++ b/tools/gn/target_generator.cc

@@ -264,7 +264,7 @@ bool TargetGenerator::EnsureSubstitutionIsInOutputDir(

// If the first thing is a literal, it must start with the output dir.

if (!EnsureStringIsInOutputDir(

GetBuildSettings()->build_dir(),

- pattern.ranges()[0].literal, original_value, err_))

+ pattern.ranges()[0].literal, original_value.origin(), err_))

return false;

} else {

// Otherwise, the first subrange must be a pattern that expands to

« no previous file with comments | « tools/gn/target.cc ('k') | tools/gn/target_unittest.cc » ('j') | no next file with comments »