Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: tools/gn/substitution_list.cc

Issue 440333002: Support more configurability in GN toolchains (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: unsigned check Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/substitution_list.h ('k') | tools/gn/substitution_pattern.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/substitution_list.cc
diff --git a/tools/gn/substitution_list.cc b/tools/gn/substitution_list.cc
index 26b3909e7980b28a164488c911cc1551fa49d6d6..826f2c1b43164ca2a3389b2e535218a9d70b84bd 100644
--- a/tools/gn/substitution_list.cc
+++ b/tools/gn/substitution_list.cc
@@ -25,7 +25,9 @@ bool SubstitutionList::Parse(const Value& value, Err* err) {
return false;
}
- FillRequiredTypes();
+ SubstitutionBits bits;
+ FillRequiredTypes(&bits);
+ bits.FillVector(&required_types_);
return true;
}
@@ -38,7 +40,9 @@ bool SubstitutionList::Parse(const std::vector<std::string>& values,
return false;
}
- FillRequiredTypes();
+ SubstitutionBits bits;
+ FillRequiredTypes(&bits);
+ bits.FillVector(&required_types_);
return true;
}
@@ -59,14 +63,7 @@ SubstitutionList SubstitutionList::MakeForTest(
return result;
}
-void SubstitutionList::FillRequiredTypes() {
- bool required_type_bits[SUBSTITUTION_NUM_TYPES];
- memset(&required_type_bits, 0, SUBSTITUTION_NUM_TYPES);
+void SubstitutionList::FillRequiredTypes(SubstitutionBits* bits) const {
for (size_t i = 0; i < list_.size(); i++)
- list_[i].FillRequiredTypes(required_type_bits);
-
- for (size_t i = SUBSTITUTION_FIRST_PATTERN; i < SUBSTITUTION_NUM_TYPES; i++) {
- if (required_type_bits[i])
- required_types_.push_back(static_cast<SubstitutionType>(i));
- }
+ list_[i].FillRequiredTypes(bits);
}
« no previous file with comments | « tools/gn/substitution_list.h ('k') | tools/gn/substitution_pattern.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698