Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: tools/gn/output_file.h

Issue 440333002: Support more configurability in GN toolchains (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: unsigned check Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/ninja_utils.cc ('k') | tools/gn/output_file.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/output_file.h
diff --git a/tools/gn/output_file.h b/tools/gn/output_file.h
index 252fae4492f5247e7b59e1b6f4ecf56a9bbfa8c5..eb6faf064f8c19cf32e1398a0878a34234e91633 100644
--- a/tools/gn/output_file.h
+++ b/tools/gn/output_file.h
@@ -9,24 +9,27 @@
#include "base/containers/hash_tables.h"
#include "tools/gn/build_settings.h"
-#include "tools/gn/source_file.h"
+
+class SourceFile;
// A simple wrapper around a string that indicates the string is a path
// relative to the output directory.
class OutputFile {
public:
- OutputFile() : value_() {}
- explicit OutputFile(const base::StringPiece& str)
- : value_(str.data(), str.size()) {
- }
+ OutputFile();
+ explicit OutputFile(const base::StringPiece& str);
+ OutputFile(const BuildSettings* build_settings,
+ const SourceFile& source_file);
+ ~OutputFile();
std::string& value() { return value_; }
const std::string& value() const { return value_; }
// Converts to a SourceFile by prepending the build directory to the file.
- SourceFile GetSourceFile(const BuildSettings* build_settings) const {
- return SourceFile(build_settings->build_dir().value() + value_);
- }
+ // The *Dir version requires that the current OutputFile ends in a slash, and
+ // the *File version is the opposite.
+ SourceFile AsSourceFile(const BuildSettings* build_settings) const;
+ SourceDir AsSourceDir(const BuildSettings* build_settings) const;
bool operator==(const OutputFile& other) const {
return value_ == other.value_;
« no previous file with comments | « tools/gn/ninja_utils.cc ('k') | tools/gn/output_file.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698