Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: tools/gn/ninja_toolchain_writer.h

Issue 440333002: Support more configurability in GN toolchains (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: unsigned check Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/ninja_target_writer_unittest.cc ('k') | tools/gn/ninja_toolchain_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_toolchain_writer.h
diff --git a/tools/gn/ninja_toolchain_writer.h b/tools/gn/ninja_toolchain_writer.h
index e3e26b0b7d667f27f63e6f2def77c85594e7d143..50cb7ef60db5f1e6951eceacb0e05c209c776ce6 100644
--- a/tools/gn/ninja_toolchain_writer.h
+++ b/tools/gn/ninja_toolchain_writer.h
@@ -10,13 +10,15 @@
#include <string>
#include <vector>
-#include "tools/gn/ninja_helper.h"
+#include "base/gtest_prod_util.h"
#include "tools/gn/path_output.h"
+#include "tools/gn/toolchain.h"
class BuildSettings;
+struct EscapeOptions;
class Settings;
class Target;
-class Toolchain;
+class Tool;
class NinjaToolchainWriter {
public:
@@ -27,6 +29,8 @@ class NinjaToolchainWriter {
const std::vector<const Target*>& targets);
private:
+ FRIEND_TEST_ALL_PREFIXES(NinjaToolchainWriter, WriteToolRule);
+
NinjaToolchainWriter(const Settings* settings,
const Toolchain* toolchain,
const std::vector<const Target*>& targets,
@@ -36,6 +40,12 @@ class NinjaToolchainWriter {
void Run();
void WriteRules();
+ void WriteToolRule(Toolchain::ToolType type,
+ const Tool* tool,
+ const std::string& rule_prefix);
+ void WriteRulePattern(const char* name,
+ const SubstitutionPattern& pattern,
+ const EscapeOptions& options);
void WriteSubninjas();
const Settings* settings_;
@@ -44,8 +54,6 @@ class NinjaToolchainWriter {
std::ostream& out_;
PathOutput path_output_;
- NinjaHelper helper_;
-
DISALLOW_COPY_AND_ASSIGN(NinjaToolchainWriter);
};
« no previous file with comments | « tools/gn/ninja_target_writer_unittest.cc ('k') | tools/gn/ninja_toolchain_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698