Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: tools/gn/ninja_copy_target_writer_unittest.cc

Issue 440333002: Support more configurability in GN toolchains (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: unsigned check Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/ninja_copy_target_writer.cc ('k') | tools/gn/ninja_group_target_writer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_copy_target_writer_unittest.cc
diff --git a/tools/gn/ninja_copy_target_writer_unittest.cc b/tools/gn/ninja_copy_target_writer_unittest.cc
index a99d0cb71ed5edef740ca699bac297c1959d0179..2e2169361cbdcef954214db28b8fc55669436b34 100644
--- a/tools/gn/ninja_copy_target_writer_unittest.cc
+++ b/tools/gn/ninja_copy_target_writer_unittest.cc
@@ -7,11 +7,13 @@
#include "testing/gtest/include/gtest/gtest.h"
#include "tools/gn/ninja_copy_target_writer.h"
+#include "tools/gn/target.h"
#include "tools/gn/test_with_scope.h"
// Tests mutliple files with an output pattern and no toolchain dependency.
TEST(NinjaCopyTargetWriter, Run) {
TestWithScope setup;
+
setup.settings()->set_target_os(Settings::LINUX);
setup.build_settings()->SetBuildDir(SourceDir("//out/Debug/"));
Target target(setup.settings(), Label(SourceDir("//foo/"), "bar"));
@@ -23,8 +25,11 @@ TEST(NinjaCopyTargetWriter, Run) {
target.action_values().outputs() =
SubstitutionList::MakeForTest("//out/Debug/{{source_name_part}}.out");
+ target.SetToolchain(setup.toolchain());
+ target.OnResolved();
+
std::ostringstream out;
- NinjaCopyTargetWriter writer(&target, setup.toolchain(), out);
+ NinjaCopyTargetWriter writer(&target, out);
writer.Run();
const char expected_linux[] =
@@ -39,6 +44,7 @@ TEST(NinjaCopyTargetWriter, Run) {
// Tests a single file with no output pattern.
TEST(NinjaCopyTargetWriter, ToolchainDeps) {
TestWithScope setup;
+
setup.settings()->set_target_os(Settings::LINUX);
setup.build_settings()->SetBuildDir(SourceDir("//out/Debug/"));
Target target(setup.settings(), Label(SourceDir("//foo/"), "bar"));
@@ -49,8 +55,11 @@ TEST(NinjaCopyTargetWriter, ToolchainDeps) {
target.action_values().outputs() =
SubstitutionList::MakeForTest("//out/Debug/output.out");
+ target.SetToolchain(setup.toolchain());
+ target.OnResolved();
+
std::ostringstream out;
- NinjaCopyTargetWriter writer(&target, setup.toolchain(), out);
+ NinjaCopyTargetWriter writer(&target, out);
writer.Run();
const char expected_linux[] =
« no previous file with comments | « tools/gn/ninja_copy_target_writer.cc ('k') | tools/gn/ninja_group_target_writer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698