Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: tools/gn/function_get_target_outputs_unittest.cc

Issue 440333002: Support more configurability in GN toolchains (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: unsigned check Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/function_get_target_outputs.cc ('k') | tools/gn/function_rebase_path.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/function_get_target_outputs_unittest.cc
diff --git a/tools/gn/function_get_target_outputs_unittest.cc b/tools/gn/function_get_target_outputs_unittest.cc
index a38a17e1f0639211c23c63c3f2d9ca03e9a75027..ab89343a22b12e4eca7891c453d814672fe34f55 100644
--- a/tools/gn/function_get_target_outputs_unittest.cc
+++ b/tools/gn/function_get_target_outputs_unittest.cc
@@ -58,30 +58,6 @@ class GetTargetOutputsTest : public testing::Test {
} // namespace
-TEST_F(GetTargetOutputsTest, Executable) {
- Target* exe = new Target(setup_.settings(), GetLabel("//foo/", "bar"));
- exe->set_output_type(Target::EXECUTABLE);
- items_.push_back(new scoped_ptr<Item>(exe));
-
- Err err;
- Value result = GetTargetOutputs("//foo:bar", &err);
- ASSERT_FALSE(err.has_error());
- // The TestWithScope declares that the build is Linux, so we'll have no
- // extension for the binaries.
- AssertSingleStringEquals(result, "//out/Debug/bar");
-}
-
-TEST_F(GetTargetOutputsTest, SourceSet) {
- Target* source_set = new Target(setup_.settings(), GetLabel("//foo/", "bar"));
- source_set->set_output_type(Target::SOURCE_SET);
- items_.push_back(new scoped_ptr<Item>(source_set));
-
- Err err;
- Value result = GetTargetOutputs("//foo:bar", &err);
- ASSERT_FALSE(err.has_error());
- AssertSingleStringEquals(result, "//out/Debug/obj/foo/bar.stamp");
-}
-
TEST_F(GetTargetOutputsTest, Copy) {
Target* action = new Target(setup_.settings(), GetLabel("//foo/", "bar"));
action->set_output_type(Target::COPY_FILES);
« no previous file with comments | « tools/gn/function_get_target_outputs.cc ('k') | tools/gn/function_rebase_path.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698