Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: tools/gn/command_gen.cc

Issue 440333002: Support more configurability in GN toolchains (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: unsigned check Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/builder_unittest.cc ('k') | tools/gn/config_values_extractors_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/command_gen.cc
diff --git a/tools/gn/command_gen.cc b/tools/gn/command_gen.cc
index 086789df7830f162871e60e512b09bef21222977..0df121a954f0d1d5a73f121427ef185bda9cded7 100644
--- a/tools/gn/command_gen.cc
+++ b/tools/gn/command_gen.cc
@@ -14,6 +14,7 @@
#include "tools/gn/scheduler.h"
#include "tools/gn/setup.h"
#include "tools/gn/standard_out.h"
+#include "tools/gn/target.h"
namespace commands {
@@ -25,7 +26,6 @@ const char kSwitchQuiet[] = "q";
const char kSwitchCheck[] = "check";
void BackgroundDoWrite(const Target* target,
- const Toolchain* toolchain,
const std::vector<const Item*>& deps_for_visibility) {
// Validate visibility.
Err err;
@@ -38,7 +38,7 @@ void BackgroundDoWrite(const Target* target,
}
if (!err.has_error())
- NinjaTargetWriter::RunAndWriteFile(target, toolchain);
+ NinjaTargetWriter::RunAndWriteFile(target);
g_scheduler->DecrementWorkCount();
}
@@ -51,10 +51,6 @@ void ItemResolvedCallback(base::subtle::Atomic32* write_counter,
const Item* item = record->item();
const Target* target = item->AsTarget();
if (target) {
- const Toolchain* toolchain =
- builder->GetToolchain(target->settings()->toolchain_label());
- DCHECK(toolchain);
-
// Collect all dependencies.
std::vector<const Item*> deps;
for (BuilderRecord::BuilderRecordSet::const_iterator iter =
@@ -64,8 +60,7 @@ void ItemResolvedCallback(base::subtle::Atomic32* write_counter,
deps.push_back((*iter)->item());
g_scheduler->IncrementWorkCount();
- g_scheduler->ScheduleWork(
- base::Bind(&BackgroundDoWrite, target, toolchain, deps));
+ g_scheduler->ScheduleWork(base::Bind(&BackgroundDoWrite, target, deps));
}
}
« no previous file with comments | « tools/gn/builder_unittest.cc ('k') | tools/gn/config_values_extractors_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698