pylib/gyp/generator/ninja.py - Issue 440293002: Provide a way to suppress implicit MIDL generation rules for actions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pylib/gyp/generator/ninja.py

Issue 440293002: Provide a way to suppress implicit MIDL generation rules for actions (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pylib/gyp/generator/ninja.py

diff --git a/pylib/gyp/generator/ninja.py b/pylib/gyp/generator/ninja.py

index 7cdb0e80e6058ed5a745c53b098f99b33d9f68df..08e48fe24b54bc2da304e10ab8da3944301d5ce2 100644

--- a/pylib/gyp/generator/ninja.py

+++ b/pylib/gyp/generator/ninja.py

@@ -530,7 +530,7 @@ class NinjaWriter:

def WriteWinIdlFiles(self, spec, prebuild):

"""Writes rules to match MSVS's implicit idl handling."""

assert self.flavor == 'win'

- if self.msvs_settings.HasExplicitIdlRules(spec):

+ if self.msvs_settings.HasExplicitIdlRulesOrActions(spec):

return []

outputs = []

for source in filter(lambda x: x.endswith('.idl'), spec['sources']):

« no previous file with comments | « no previous file | pylib/gyp/msvs_emulation.py » ('j') | test/win/idl-rules/basic-idl.gyp » ('J')