Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: pylib/gyp/generator/ninja.py

Issue 440293002: Provide a way to suppress implicit MIDL generation rules for actions (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | pylib/gyp/msvs_emulation.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 Google Inc. All rights reserved. 1 # Copyright (c) 2013 Google Inc. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import collections 5 import collections
6 import copy 6 import copy
7 import hashlib 7 import hashlib
8 import json 8 import json
9 import multiprocessing 9 import multiprocessing
10 import os.path 10 import os.path
(...skipping 512 matching lines...) Expand 10 before | Expand all | Expand 10 after
523 vars.append(('outdir', outdir)) 523 vars.append(('outdir', outdir))
524 vars.append(('idlflags', flags)) 524 vars.append(('idlflags', flags))
525 input = self.GypPathToNinja(source) 525 input = self.GypPathToNinja(source)
526 self.ninja.build(output, 'idl', input, 526 self.ninja.build(output, 'idl', input,
527 variables=vars, order_only=prebuild) 527 variables=vars, order_only=prebuild)
528 outputs.extend(output) 528 outputs.extend(output)
529 529
530 def WriteWinIdlFiles(self, spec, prebuild): 530 def WriteWinIdlFiles(self, spec, prebuild):
531 """Writes rules to match MSVS's implicit idl handling.""" 531 """Writes rules to match MSVS's implicit idl handling."""
532 assert self.flavor == 'win' 532 assert self.flavor == 'win'
533 if self.msvs_settings.HasExplicitIdlRules(spec): 533 if self.msvs_settings.HasExplicitIdlRulesOrActions(spec):
534 return [] 534 return []
535 outputs = [] 535 outputs = []
536 for source in filter(lambda x: x.endswith('.idl'), spec['sources']): 536 for source in filter(lambda x: x.endswith('.idl'), spec['sources']):
537 self._WinIdlRule(source, prebuild, outputs) 537 self._WinIdlRule(source, prebuild, outputs)
538 return outputs 538 return outputs
539 539
540 def WriteActionsRulesCopies(self, spec, extra_sources, prebuild, 540 def WriteActionsRulesCopies(self, spec, extra_sources, prebuild,
541 mac_bundle_depends): 541 mac_bundle_depends):
542 """Write out the Actions, Rules, and Copies steps. Return a path 542 """Write out the Actions, Rules, and Copies steps. Return a path
543 representing the outputs of these steps.""" 543 representing the outputs of these steps."""
(...skipping 1686 matching lines...) Expand 10 before | Expand all | Expand 10 after
2230 arglists.append( 2230 arglists.append(
2231 (target_list, target_dicts, data, params, config_name)) 2231 (target_list, target_dicts, data, params, config_name))
2232 pool.map(CallGenerateOutputForConfig, arglists) 2232 pool.map(CallGenerateOutputForConfig, arglists)
2233 except KeyboardInterrupt, e: 2233 except KeyboardInterrupt, e:
2234 pool.terminate() 2234 pool.terminate()
2235 raise e 2235 raise e
2236 else: 2236 else:
2237 for config_name in config_names: 2237 for config_name in config_names:
2238 GenerateOutputForConfig(target_list, target_dicts, data, params, 2238 GenerateOutputForConfig(target_list, target_dicts, data, params,
2239 config_name) 2239 config_name)
OLDNEW
« no previous file with comments | « no previous file | pylib/gyp/msvs_emulation.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698