Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 440263002: Revert of Add --no-history option to fetch and gclient for shallow clones. (Closed)

Created:
6 years, 4 months ago by Primiano Tucci (use gerrit)
Modified:
6 years, 4 months ago
Reviewers:
iannucci, wtc, szager1
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org, hinoka, cmp
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Project:
tools
Visibility:
Public.

Description

Revert of Add --no-history option to fetch and gclient for shallow clones. (https://codereview.chromium.org/437903002/) Reason for revert: Broke the WebRTC waterfall: http://build.chromium.org/p/tryserver.webrtc/builders/win/builds/3958/steps/gclient%20revert/logs/stdio Original issue's description: > Add --no-history option to fetch and gclient for shallow clones. > > Many people* have complained on chromium-dev about the long times > required to perform a full fetch over a DSL. This seems to be mostly > due to the huge size of chromium's history (~9 GB). On the other side, > not everybody is interested in downloading the full git history of > the projects. The size of git packs required to fetch a working HEAD > is one order of magnitude smaller (1.5 GB). > This change makes it possible to perform a shallow fetch (in a way > which is consistent with DEPS, leveraging git templates on clone), > reducing fetch times by 80% for those not interested in the history. > > * See: > [chromium-dev] "fetch chromium" keeps hanging/getting stuck on Windows 7 > [chromium-dev] Initial checkout with git taking long > [chromium-dev] Trying to get latest source code fails when fetching > [chromium-dev] Gclient sync takes too long > > BUG=228996 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=287606 TBR=iannucci@chromium.org,szager@chromium.org,wtc@chromium.org NOTREECHECKS=true NOTRY=true BUG=228996 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=287637

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -85 lines) Patch
M fetch.py View 5 chunks +1 line, -11 lines 0 comments Download
M gclient.py View 1 chunk +0 lines, -3 lines 0 comments Download
M gclient_scm.py View 2 chunks +0 lines, -21 lines 0 comments Download
M gclient_utils.py View 1 chunk +0 lines, -5 lines 0 comments Download
M tests/gclient_scm_test.py View 3 chunks +3 lines, -4 lines 0 comments Download
M tests/gclient_smoketest.py View 1 chunk +0 lines, -41 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Primiano Tucci (use gerrit)
Created Revert of Add --no-history option to fetch and gclient for shallow clones.
6 years, 4 months ago (2014-08-05 23:14:48 UTC) #1
Primiano Tucci (use gerrit)
More details about the breakage: Traceback (most recent call last): File "E:\b\depot_tools\\gclient.py", line 2067, in ...
6 years, 4 months ago (2014-08-05 23:15:57 UTC) #2
Primiano Tucci (use gerrit)
The CQ bit was checked by primiano@chromium.org
6 years, 4 months ago (2014-08-05 23:16:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/primiano@chromium.org/440263002/1
6 years, 4 months ago (2014-08-05 23:16:52 UTC) #4
commit-bot: I haz the power
Change committed as 287637
6 years, 4 months ago (2014-08-05 23:19:31 UTC) #5
iannucci
On 2014/08/05 23:19:31, I haz the power (commit-bot) wrote: > Change committed as 287637 Aww... ...
6 years, 4 months ago (2014-08-06 18:44:51 UTC) #6
Primiano Tucci (use gerrit)
6 years, 4 months ago (2014-08-06 19:07:16 UTC) #7
Message was sent while issue was closed.
On 2014/08/06 18:44:51, iannucci wrote:
> On 2014/08/05 23:19:31, I haz the power (commit-bot) wrote:
> > Change committed as 287637
> 
> Aww... I was going to recommend filling in options.no_history at the point
where
> we parse the option. The problem with this approach is that it can lead to
> copy-pasta, and suddenly we have 2 (or 3, or 4) places where 'False' is a
local,
> implied default. Then someone gets clever and changes the local default to
True
> in one of the places, and we have chaos :(

Robert and I had an offline chat on this. The point is that even filling the
options is not going to solve the problem (if the default changes, we need to
change all the = False filling assignments).
On the other side, there seem to be already precedent for this
(with_branch_heads), so we decided to stay consistent. Also, at current state,
there is only one place evaluating no_history and, honestly, I wouldn't expect
more.

Powered by Google App Engine
This is Rietveld 408576698