[CSS Grid Layout] Ignore ::first-letter pseudo-element

Source/core/rendering/RenderBlock.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2007 David Smith (catfish.man@gmail.com)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) Research In Motion Limited 2010. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 3980 matching lines @@
     RenderObject* firstLetterBlock = start;
     while (true) {
         // We include isRenderButton in these two checks because buttons are
         // implemented using flex box but should still support first-letter.
         // The flex box spec requires that flex box does not support
         // first-letter, though.
         // FIXME: Remove when buttons are implemented with align-items instead
         // of flexbox.
         bool canHaveFirstLetterRenderer = firstLetterBlock->style()->hasPseudoStyle(FIRST_LETTER)
             && firstLetterBlock->canHaveGeneratedChildren()
-            && (!firstLetterBlock->isFlexibleBox() || firstLetterBlock->isRenderButton());
+            && (firstLetterBlock->isRenderBlockFlow() || firstLetterBlock->isRenderButton());
         if (canHaveFirstLetterRenderer)
             return firstLetterBlock;
 
         RenderObject* parentBlock = firstLetterBlock->parent();
         if (firstLetterBlock->isReplaced() || !parentBlock
             || (!parentBlock->isRenderBlockFlow() && !parentBlock->isRenderButton())) {
             return 0;
         }
         ASSERT(parentBlock->isRenderBlock());
         if (toRenderBlock(parentBlock)->firstChild() != firstLetterBlock)
@@ skipping 157 matching lines @@
                 break;
             currChild = currChild->nextSibling();
         } else if (currChild->isListMarker()) {
             currChild = currChild->nextSibling();
         } else if (currChild->isFloatingOrOutOfFlowPositioned()) {
             if (currChild->style()->styleType() == FIRST_LETTER) {
                 currChild = currChild->slowFirstChild();
                 break;
             }
             currChild = currChild->nextSibling();
-        } else if (currChild->isReplaced() || currChild->isRenderButton() || currChild->isMenuList()) {
+        } else if (currChild->isReplaced() || currChild->isRenderButton() || currChild->isMenuList() || (!firstLetterBlock->isRenderBlockFlow() && !firstLetterBlock->isRenderButton())) {

[Julien - ping for review, 2014/08/07 20:55:57]

This is repeated several now so we should put it into its own function:

firstLetterBlock->isRenderBlockFlow() || firstLetterBlock->isRenderButton()

The upside is that you could also hoist the existing comment about why we have a
isRenderButton() check.

[Manuel Rego, 2014/08/07 22:19:47]

Done.

             break;
         } else if (currChild->style()->hasPseudoStyle(FIRST_LETTER) && currChild->canHaveGeneratedChildren())  {
             // We found a lower-level node with first-letter, which supersedes the higher-level style
             firstLetterBlock = currChild;
             currChild = currChild->slowFirstChild();
         } else {
             currChild = currChild->slowFirstChild();
         }
     }
 
@@ skipping 645 matching lines @@
 void RenderBlock::showLineTreeAndMark(const InlineBox* markedBox1, const char* markedLabel1, const InlineBox* markedBox2, const char* markedLabel2, const RenderObject* obj) const
 {
     showRenderObject();
     for (const RootInlineBox* root = firstRootBox(); root; root = root->nextRootBox())
         root->showLineTreeAndMark(markedBox1, markedLabel1, markedBox2, markedLabel2, obj, 1);
 }
 
 #endif
 
 } // namespace blink