Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 440213005: Add 'git cache fetch' subcommand. (Closed)

Created:
6 years, 4 months ago by szager1
Modified:
6 years, 4 months ago
Reviewers:
agable, iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Project:
tools
Visibility:
Public.

Description

Add 'git cache fetch' subcommand. If you're in a git checkout cloned from the git cache, this will: - Update the cache with the latest upstream commits. - Update the cwd with the latest commits from the cache. For example: > cd $HOME/workspace/chromium/src > git cache fetch R=agable@chromium.org,iannucci@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=288140

Patch Set 1 #

Total comments: 5

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -0 lines) Patch
M git_cache.py View 1 2 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
szager1
6 years, 4 months ago (2014-08-07 18:09:24 UTC) #1
iannucci
like the idea :) https://codereview.chromium.org/440213005/diff/1/git_cache.py File git_cache.py (right): https://codereview.chromium.org/440213005/diff/1/git_cache.py#newcode582 git_cache.py:582: current_branch = subprocess.check_output( won't this ...
6 years, 4 months ago (2014-08-07 18:29:53 UTC) #2
szager1
https://codereview.chromium.org/440213005/diff/1/git_cache.py File git_cache.py (right): https://codereview.chromium.org/440213005/diff/1/git_cache.py#newcode582 git_cache.py:582: current_branch = subprocess.check_output( On 2014/08/07 18:29:53, iannucci wrote: > ...
6 years, 4 months ago (2014-08-07 18:32:54 UTC) #3
szager1
https://codereview.chromium.org/440213005/diff/1/git_cache.py File git_cache.py (right): https://codereview.chromium.org/440213005/diff/1/git_cache.py#newcode582 git_cache.py:582: current_branch = subprocess.check_output( On 2014/08/07 18:32:53, szager1 wrote: > ...
6 years, 4 months ago (2014-08-07 18:38:48 UTC) #4
iannucci
On 2014/08/07 18:32:54, szager1 wrote: > https://codereview.chromium.org/440213005/diff/1/git_cache.py > File git_cache.py (right): > > https://codereview.chromium.org/440213005/diff/1/git_cache.py#newcode582 > ...
6 years, 4 months ago (2014-08-07 18:40:21 UTC) #5
szager1
On 2014/08/07 18:40:21, iannucci wrote: > On 2014/08/07 18:32:54, szager1 wrote: > > https://codereview.chromium.org/440213005/diff/1/git_cache.py > ...
6 years, 4 months ago (2014-08-07 18:51:05 UTC) #6
iannucci
On 2014/08/07 18:51:05, szager1 wrote: > On 2014/08/07 18:40:21, iannucci wrote: > > On 2014/08/07 ...
6 years, 4 months ago (2014-08-07 20:26:46 UTC) #7
iannucci
lgtm, could you just add a TODO about stacked branches for now?
6 years, 4 months ago (2014-08-07 20:27:07 UTC) #8
szager1
On 2014/08/07 20:26:46, iannucci wrote: > On 2014/08/07 18:51:05, szager1 wrote: > > On 2014/08/07 ...
6 years, 4 months ago (2014-08-07 20:34:31 UTC) #9
szager1
The CQ bit was checked by szager@chromium.org
6 years, 4 months ago (2014-08-07 20:59:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szager@chromium.org/440213005/40001
6 years, 4 months ago (2014-08-07 21:00:04 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 21:02:39 UTC) #12
Message was sent while issue was closed.
Change committed as 288140

Powered by Google App Engine
This is Rietveld 408576698