Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 440213004: Support float widths in RenderTextHarfBuzz. (Closed)

Created:
6 years, 4 months ago by msw
Modified:
6 years, 4 months ago
CC:
chromium-reviews, Andre
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Support float widths in RenderTextHarfBuzz. The gfx_unittests CanvasTestMac.* passes on Mac Views. (can also run the tests with --enable-harfbuzz-rendertext) BUG=391843 TEST=CanvasTestMac.* passes, no Mac text rendering changes. R=asvitkine@chromium.org,ckocagil@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288255

Patch Set 1 #

Patch Set 2 : Avoid rounding for run lengths and glyph bounds. #

Patch Set 3 : Sync and rebase. #

Patch Set 4 : Update RenderTextWin minimally. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -25 lines) Patch
M ui/gfx/render_text.h View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M ui/gfx/render_text_harfbuzz.h View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M ui/gfx/render_text_harfbuzz.cc View 1 2 8 chunks +21 lines, -17 lines 0 comments Download
M ui/gfx/render_text_win.cc View 1 2 3 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
msw
Hey Cem and Alexei, please take a look; thanks!
6 years, 4 months ago (2014-08-07 20:20:37 UTC) #1
Alexei Svitkine (slow)
This change LGTM I think it's the right direction for RenderText. However, I don't think ...
6 years, 4 months ago (2014-08-07 20:52:29 UTC) #2
msw
The CQ bit was checked by msw@chromium.org
6 years, 4 months ago (2014-08-07 20:53:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/440213004/60001
6 years, 4 months ago (2014-08-07 21:08:02 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win8_chromium_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-08 00:59:34 UTC) #5
commit-bot: I haz the power
Change committed as 288255
6 years, 4 months ago (2014-08-08 08:25:27 UTC) #6
ckocagil
6 years, 4 months ago (2014-08-08 17:26:02 UTC) #7
Message was sent while issue was closed.
lgtm with this comment: I'm thinking if it would be better to only use
fixed-point integers internally and only convert to float when it is needed.

Powered by Google App Engine
This is Rietveld 408576698