|
|
Merge 283085 "Added more detailed result codes for CreateViewCom..."
Merged to branch 2062 / M37.
Only conflict was in context_lost.py with new test. Resolved manually.
> Added more detailed result codes for CreateViewCommandBuffer.
>
> Creation of a view command buffer can legitimately fail if the surface
> has unexpectedly been deleted, for example if the window has been
> rapidly opened and closed. This should not cause loss of the entire
> GpuChannel for the associated renderer process.
>
> Added new automated test for this issue. Also tested manually with
> test case from bug report, and increased number_of_gpu_process_kills
> in context_lost test to 30 and verified that previous fix for Issue
> 365904 continues to work.
>
> BUG= 381024
> R=piman@chromium.org,danakj@chromium.org,jamesr@chromium.org
>
> Review URL: https://codereview.chromium.org/383303004
TBR=kbr@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287583
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+92 lines, -41 lines) |
Patch |
 |
M |
content/browser/gpu/browser_gpu_channel_host_factory.h
|
View
|
|
2 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
content/browser/gpu/browser_gpu_channel_host_factory.cc
|
View
|
|
3 chunks |
+7 lines, -6 lines |
0 comments
|
Download
|
|
M |
content/browser/gpu/gpu_process_host.h
|
View
|
|
3 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
|
M |
content/browser/gpu/gpu_process_host.cc
|
View
|
|
4 chunks |
+6 lines, -4 lines |
0 comments
|
Download
|
|
M |
content/browser/renderer_host/gpu_message_filter.h
|
View
|
|
2 chunks |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
content/browser/renderer_host/gpu_message_filter.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
content/common/gpu/client/gpu_channel_host.h
|
View
|
|
2 chunks |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
content/common/gpu/client/gpu_channel_host.cc
|
View
|
|
1 chunk |
+16 lines, -11 lines |
0 comments
|
Download
|
|
M |
content/common/gpu/gpu_channel.h
|
View
|
|
2 chunks |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
content/common/gpu/gpu_channel.cc
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
content/common/gpu/gpu_channel_manager.cc
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
content/common/gpu/gpu_messages.h
|
View
|
|
4 chunks |
+5 lines, -2 lines |
0 comments
|
Download
|
|
A + |
content/common/gpu/gpu_result_codes.h
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
|
M |
content/content_common.gypi
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
content/renderer/render_thread_impl.h
|
View
|
|
2 chunks |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
content/renderer/render_thread_impl.cc
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
|
A + |
content/test/data/gpu/webgl_with_select_element.html
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
|
M |
content/test/gpu/gpu_tests/context_lost.py
|
View
|
|
3 chunks |
+32 lines, -0 lines |
0 comments
|
Download
|
Total messages: 2 (0 generated)
|
Chromium Code Reviews
Issue
440203002:
Merge 283085 "Added more detailed result codes for CreateViewCom..." (Closed)
