Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4785)

Unified Diff: cc/output/overlay_strategy_single_on_top.cc

Issue 440193002: Let OverlayStrategySingleOnTop select non-topmost quad (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: split patch Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/output/overlay_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/overlay_strategy_single_on_top.cc
diff --git a/cc/output/overlay_strategy_single_on_top.cc b/cc/output/overlay_strategy_single_on_top.cc
index e8971b845459e355a85719fe7c9e956b8e3a76e1..64ebf7c5c5e7b4cec738e427e9256ff2ab6e54c1 100644
--- a/cc/output/overlay_strategy_single_on_top.cc
+++ b/cc/output/overlay_strategy_single_on_top.cc
@@ -28,13 +28,38 @@ bool OverlayStrategySingleOnTop::Attempt(
DCHECK(root_render_pass);
QuadList& quad_list = root_render_pass->quad_list;
- const DrawQuad* candidate_quad = quad_list.front();
- if (candidate_quad->material != DrawQuad::TEXTURE_CONTENT)
- return false;
-
- const TextureDrawQuad& quad = *TextureDrawQuad::MaterialCast(candidate_quad);
- if (!resource_provider_->AllowOverlay(quad.resource_id))
+ QuadList::iterator candidate_iterator = quad_list.end();
+ for (QuadList::iterator it = quad_list.begin(); it != quad_list.end(); ++it) {
+ const DrawQuad* draw_quad = *it;
+ if (draw_quad->material == DrawQuad::TEXTURE_CONTENT) {
+ const TextureDrawQuad& quad = *TextureDrawQuad::MaterialCast(draw_quad);
+ if (!resource_provider_->AllowOverlay(quad.resource_id)) {
+ continue;
+ }
+ // Check that no prior quads overlap it.
+ bool intersects = false;
+ gfx::RectF rect = draw_quad->rect;
+ draw_quad->quadTransform().TransformRect(&rect);
+ for (QuadList::iterator overlap_iter = quad_list.begin();
+ overlap_iter != it;
+ ++overlap_iter) {
+ gfx::RectF overlap_rect = (*overlap_iter)->rect;
+ (*overlap_iter)->quadTransform().TransformRect(&overlap_rect);
+ if (rect.Intersects(overlap_rect)) {
+ intersects = true;
+ break;
+ }
+ }
+ if (intersects)
+ continue;
+ candidate_iterator = it;
+ break;
+ }
+ }
+ if (candidate_iterator == quad_list.end())
return false;
+ const TextureDrawQuad& quad =
+ *TextureDrawQuad::MaterialCast(*candidate_iterator);
// Simple quads only.
gfx::OverlayTransform overlay_transform =
@@ -69,8 +94,7 @@ bool OverlayStrategySingleOnTop::Attempt(
// If the candidate can be handled by an overlay, create a pass for it.
if (candidates[1].overlay_handled) {
- scoped_ptr<DrawQuad> overlay_quad = quad_list.take(quad_list.begin());
- quad_list.erase(quad_list.begin());
+ quad_list.erase(candidate_iterator);
candidate_list->swap(candidates);
return true;
}
« no previous file with comments | « no previous file | cc/output/overlay_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698