Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 440183002: [Android] Make getAllBookmarkIDsOrderedByCreationDate() descending order (Closed)

Created:
6 years, 4 months ago by Kibeom Kim (inactive)
Modified:
6 years, 4 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Make getAllBookmarkIDsOrderedByCreationDate() descending order BookmarksBridge#getAllBookmarkIDsOrderedByCreationDate() is used to show all bookmarks, which has to be ordered from most-recent to oldest. BUG=386785 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287726

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/bookmarks/bookmarks_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Kibeom Kim (inactive)
6 years, 4 months ago (2014-08-05 18:42:54 UTC) #1
Ted C
lgtm
6 years, 4 months ago (2014-08-05 19:29:55 UTC) #2
Kibeom Kim (inactive)
The CQ bit was checked by kkimlabs@chromium.org
6 years, 4 months ago (2014-08-05 19:36:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/440183002/1
6 years, 4 months ago (2014-08-05 19:37:36 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-05 22:51:29 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 23:28:07 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/42909)
6 years, 4 months ago (2014-08-05 23:28:08 UTC) #7
Kibeom Kim (inactive)
The CQ bit was checked by kkimlabs@chromium.org
6 years, 4 months ago (2014-08-06 00:34:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/440183002/1
6 years, 4 months ago (2014-08-06 00:36:52 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 07:20:49 UTC) #10
Message was sent while issue was closed.
Change committed as 287726

Powered by Google App Engine
This is Rietveld 408576698