Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 440163002: Win-Clang update.py: implement more principled search for CMake (Closed)

Created:
6 years, 4 months ago by hans
Modified:
6 years, 4 months ago
Reviewers:
Reid Kleckner, Nico
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Win-Clang update.py: implement more principled search for CMake BUG=82385 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287576

Patch Set 1 #

Total comments: 8

Patch Set 2 : Address thakis's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -4 lines) Patch
M tools/clang/scripts/update.py View 1 3 chunks +21 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hans
As suggested by Reid in https://code.google.com/p/chromium/issues/detail?id=397585#c15 Please take a look.
6 years, 4 months ago (2014-08-05 18:41:55 UTC) #1
Nico
lgtm https://codereview.chromium.org/440163002/diff/1/tools/clang/scripts/update.py File tools/clang/scripts/update.py (right): https://codereview.chromium.org/440163002/diff/1/tools/clang/scripts/update.py#newcode102 tools/clang/scripts/update.py:102: def AddCmakeToPath(): nit: CMake https://codereview.chromium.org/440163002/diff/1/tools/clang/scripts/update.py#newcode107 tools/clang/scripts/update.py:107: print "Already ...
6 years, 4 months ago (2014-08-05 18:48:51 UTC) #2
hans
https://codereview.chromium.org/440163002/diff/1/tools/clang/scripts/update.py File tools/clang/scripts/update.py (right): https://codereview.chromium.org/440163002/diff/1/tools/clang/scripts/update.py#newcode102 tools/clang/scripts/update.py:102: def AddCmakeToPath(): On 2014/08/05 18:48:51, Nico (away) wrote: > ...
6 years, 4 months ago (2014-08-05 18:52:40 UTC) #3
hans
The CQ bit was checked by hans@chromium.org
6 years, 4 months ago (2014-08-05 18:53:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/440163002/20001
6 years, 4 months ago (2014-08-05 18:54:07 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 19:04:34 UTC) #6
Message was sent while issue was closed. 
Change committed as 287576

Powered by Google App Engine
This is Rietveld 408576698