Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 440143002: Fix ContentVideoView to support a ContextWrapper. (Closed)

Created:
6 years, 4 months ago by Ignacio Solla
Modified:
6 years, 4 months ago
Reviewers:
benm (inactive)
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkosiba (inactive)
Project:
chromium
Visibility:
Public.

Description

Fix ContentVideoView to support a ContextWrapper. BUG=400755 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287764

Patch Set 1 #

Patch Set 2 : Fix failing tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java View 1 3 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Ignacio Solla
6 years, 4 months ago (2014-08-05 17:25:52 UTC) #1
benm (inactive)
lgtm
6 years, 4 months ago (2014-08-05 17:29:58 UTC) #2
Ignacio Solla
The CQ bit was checked by igsolla@chromium.org
6 years, 4 months ago (2014-08-05 17:31:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/igsolla@chromium.org/440143002/1
6 years, 4 months ago (2014-08-05 17:32:58 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-05 20:51:01 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 21:24:13 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_triggered_tests/builds/2745)
6 years, 4 months ago (2014-08-05 21:24:13 UTC) #7
Ignacio Solla
The CQ bit was checked by igsolla@chromium.org
6 years, 4 months ago (2014-08-06 10:01:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/igsolla@chromium.org/440143002/20001
6 years, 4 months ago (2014-08-06 10:02:26 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 12:17:25 UTC) #10
Message was sent while issue was closed.
Change committed as 287764

Powered by Google App Engine
This is Rietveld 408576698