Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 440123002: Remove unused methods from GoogleLocationSettingsHelper (Closed)

Created:
6 years, 4 months ago by Miguel Garcia
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Remove unused methods from GoogleLocationSettingsHelper Depends on https://codereview.chromium.org/441883003/ and an additional downstream patch BUG=400694 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288111

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -46 lines) Patch
M chrome/browser/android/google_location_settings_helper.h View 1 chunk +1 line, -11 lines 0 comments Download
D chrome/browser/android/google_location_settings_helper.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M chrome/browser/android/mock_google_location_settings_helper.h View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/android/mock_google_location_settings_helper.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Miguel Garcia
Last patch of the 3 sided commit with the cleanup of the unused methods.
6 years, 4 months ago (2014-08-05 16:55:48 UTC) #1
Michael van Ouwerkerk
lgtm - looks like you know where you're going with this :-)
6 years, 4 months ago (2014-08-06 10:50:15 UTC) #2
Miguel Garcia
The CQ bit was checked by miguelg@chromium.org
6 years, 4 months ago (2014-08-07 09:23:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miguelg@chromium.org/440123002/1
6 years, 4 months ago (2014-08-07 09:24:23 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-07 11:53:32 UTC) #5
commit-bot: I haz the power
Failed to commit the patch. Deleting chrome/browser/android/google_location_settings_helper.cc Sending chrome/browser/android/google_location_settings_helper.h Sending chrome/browser/android/mock_google_location_settings_helper.cc Sending chrome/browser/android/mock_google_location_settings_helper.h Sending chrome/chrome_browser.gypi ...
6 years, 4 months ago (2014-08-07 11:53:33 UTC) #6
Miguel Garcia
The CQ bit was checked by miguelg@chromium.org
6 years, 4 months ago (2014-08-07 13:00:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miguelg@chromium.org/440123002/20001
6 years, 4 months ago (2014-08-07 13:01:26 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-07 18:29:18 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 19:33:11 UTC) #10
Message was sent while issue was closed.
Change committed as 288111

Powered by Google App Engine
This is Rietveld 408576698