Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 440063002: Move ClearNonLiveReferences and friends into the gc. (Closed)

Created:
6 years, 4 months ago by Hannes Payer (out of office)
Modified:
6 years, 4 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Move ClearNonLiveReferences and friends into the gc. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22864

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -114 lines) Patch
M src/heap/mark-compact.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/heap/mark-compact.cc View 1 2 1 chunk +111 lines, -1 line 0 comments Download
M src/objects.cc View 1 1 chunk +0 lines, -113 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Hannes Payer (out of office)
6 years, 4 months ago (2014-08-05 11:33:01 UTC) #1
Michael Starzinger
LGTM with one nit. https://codereview.chromium.org/440063002/diff/20001/src/heap/mark-compact.h File src/heap/mark-compact.h (right): https://codereview.chromium.org/440063002/diff/20001/src/heap/mark-compact.h#newcode814 src/heap/mark-compact.h:814: void ClearNonLiveMapTransitions(Map* map); nit: This ...
6 years, 4 months ago (2014-08-05 11:47:38 UTC) #2
Hannes Payer (out of office)
https://codereview.chromium.org/440063002/diff/20001/src/heap/mark-compact.h File src/heap/mark-compact.h (right): https://codereview.chromium.org/440063002/diff/20001/src/heap/mark-compact.h#newcode814 src/heap/mark-compact.h:814: void ClearNonLiveMapTransitions(Map* map); On 2014/08/05 11:47:38, Michael Starzinger wrote: ...
6 years, 4 months ago (2014-08-05 11:52:50 UTC) #3
Hannes Payer (out of office)
6 years, 4 months ago (2014-08-05 11:58:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as 22864 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698