Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 440053002: Update and extend context specialization. (Closed)

Created:
6 years, 4 months ago by sigurds
Modified:
6 years, 4 months ago
Reviewers:
Michael Starzinger
Project:
v8
Visibility:
Public.

Description

Update and extend context specialization. * Add store-chain folding to context specialization. * Replace all uses of context with constant and then use a visitor to find the places to optimize. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22993

Patch Set 1 #

Total comments: 8

Patch Set 2 : Update and extend context specialization. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -50 lines) Patch
M src/compiler/js-context-specialization.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M src/compiler/js-context-specialization.cc View 1 4 chunks +83 lines, -18 lines 0 comments Download
M test/cctest/compiler/test-js-context-specialization.cc View 1 4 chunks +88 lines, -31 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sigurds
6 years, 4 months ago (2014-08-05 11:04:31 UTC) #1
Michael Starzinger
LGTM (only nits to address). https://codereview.chromium.org/440053002/diff/1/src/compiler/js-context-specialization.cc File src/compiler/js-context-specialization.cc (right): https://codereview.chromium.org/440053002/diff/1/src/compiler/js-context-specialization.cc#newcode88 src/compiler/js-context-specialization.cc:88: static_cast<Operator1<ContextAccess>*>(node->op())->parameter(); nit: I know ...
6 years, 4 months ago (2014-08-08 10:00:17 UTC) #2
sigurds
https://codereview.chromium.org/440053002/diff/1/src/compiler/js-context-specialization.cc File src/compiler/js-context-specialization.cc (right): https://codereview.chromium.org/440053002/diff/1/src/compiler/js-context-specialization.cc#newcode88 src/compiler/js-context-specialization.cc:88: static_cast<Operator1<ContextAccess>*>(node->op())->parameter(); On 2014/08/08 10:00:17, Michael Starzinger wrote: > nit: ...
6 years, 4 months ago (2014-08-08 11:00:12 UTC) #3
sigurds
6 years, 4 months ago (2014-08-08 11:05:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as 22993 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698