Issue 44001: Move forked, DevTools-specific JS files out of third_party/WebKit...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 44001: Move forked, DevTools-specific JS files out of third_party/WebKit... (Closed)

Created:
11 years, 9 months ago by dglazkov

Modified:
9 years, 6 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Move forked, DevTools-specific JS files out of third_party/WebKit R=darin BUG=3320 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11358

Patch Set 1 #

Total comments: 1

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -7 lines)			Patch
	M	webkit/build/port/port.vcproj	View		1 chunk	+6 lines, -7 lines	0 comments	Download
	A	webkit/inspector/README	View		1 chunk	+4 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

11 years, 9 months ago (2009-03-10 18:10:42 UTC) #2

LGTM

http://codereview.chromium.org/44001/diff/1/3
File webkit/inspector/README (right):

http://codereview.chromium.org/44001/diff/1/3#newcode4
Line 4: Our intent is to upstream or unfork these as soon as possible.
would be good to add some guidelines here (be really obnoxious) so that newbies
understand what it means to modify files in here and how to go about doing so.

Expand Messages | Collapse Messages