Show chromium os version in about panel

Show chromium os version in about panel

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33293

[DaveMoore, 2009-11-24 18:22:40]

- Show cros version in About panel
- Make links from About panel open in new tab on cros

[sky, 2009-11-24 18:46:57]

LGTM

http://codereview.chromium.org/440008/diff/2001/2003
File chrome/browser/views/about_chrome_view.h (right):

http://codereview.chromium.org/440008/diff/2001/2003#newcode16
chrome/browser/views/about_chrome_view.h:16: #endif
How about #else if instead of another #if.

[Finnur, 2009-11-24 18:54:38]

http://codereview.chromium.org/440008/diff/2001/2002
File chrome/browser/views/about_chrome_view.cc (right):

http://codereview.chromium.org/440008/diff/2001/2002#newcode769
chrome/browser/views/about_chrome_view.cc:769: browser->OpenURL(url, GURL(),
NEW_FOREGROUND_TAB, PageTransition::LINK);
Won't this open a tab behind the About box, which the user cannot get to but by
closing the About box? Is that better than the current behavior?

[davemoore (google), 2009-11-24 20:35:36]

On ChromeOS it is, as the alternative is a new window that also appears
behind the About panel.

Dave

On Tue, Nov 24, 2009 at 10:54 AM, <finnur@chromium.org> wrote:

>
> http://codereview.chromium.org/440008/diff/2001/2002
> File chrome/browser/views/about_chrome_view.cc (right):
>
> http://codereview.chromium.org/440008/diff/2001/2002#newcode769
> chrome/browser/views/about_chrome_view.cc:769: browser->OpenURL(url,
> GURL(), NEW_FOREGROUND_TAB, PageTransition::LINK);
> Won't this open a tab behind the About box, which the user cannot get to
> but by closing the About box? Is that better than the current behavior?
>
>
> http://codereview.chromium.org/440008
>

[Finnur, 2009-11-24 20:37:58]

OK.

On Tue, Nov 24, 2009 at 12:35, David Moore <davemoore@google.com> wrote:

> On ChromeOS it is, as the alternative is a new window that also appears
> behind the About panel.
>
> Dave
>
>
> On Tue, Nov 24, 2009 at 10:54 AM, <finnur@chromium.org> wrote:
>
>>
>> http://codereview.chromium.org/440008/diff/2001/2002
>> File chrome/browser/views/about_chrome_view.cc (right):
>>
>> http://codereview.chromium.org/440008/diff/2001/2002#newcode769
>> chrome/browser/views/about_chrome_view.cc:769: browser->OpenURL(url,
>> GURL(), NEW_FOREGROUND_TAB, PageTransition::LINK);
>> Won't this open a tab behind the About box, which the user cannot get to
>> but by closing the About box? Is that better than the current behavior?
>>
>>
>> http://codereview.chromium.org/440008
>>
>
>