Issue 439943003: Disable flaky BenchmarkSmokeTest.thread_times.simple_mobile_sites

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 439943003: Disable flaky BenchmarkSmokeTest.thread_times.simple_mobile_sites (Closed)

Created:
6 years, 4 months ago by Paweł Hajdan Jr.

Modified:
6 years, 4 months ago

Reviewers:
tonyg

CC:
chromium-reviews, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Disable flaky BenchmarkSmokeTest.thread_times.simple_mobile_sites TBR=tonyg BUG=366899, 400747 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287544

Patch Set 1 #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	tools/perf/benchmarks/benchmark_unittest.py	View		1 chunk	+2 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

Committed patchset #1 manually as 287544 (presubmit successful).

6 years, 4 months ago (2014-08-05 15:15:48 UTC) #1

tonyg

6 years, 4 months ago (2014-08-05 15:19:46 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/439943003/diff/1/tools/perf/benchmarks/benchm...
File tools/perf/benchmarks/benchmark_unittest.py (right):

https://codereview.chromium.org/439943003/diff/1/tools/perf/benchmarks/benchm...
tools/perf/benchmarks/benchmark_unittest.py:27:
@benchmark_module.Disabled('mac')
This isn't the right fix for this. Please see comment above.

Instead we should disable the thread_times.simple_mobile_sites benchmark.

Expand Messages | Collapse Messages