Prioritizing input and compositor tasks in the blink scheduler.

Source/platform/scheduler/Scheduler.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef Scheduler_h
 #define Scheduler_h
 
 #include "platform/PlatformExport.h"
+#include "platform/TraceLocation.h"
+#include "public/platform/WebThread.h"
+#include "wtf/Deque.h"
 #include "wtf/Functional.h"
 #include "wtf/Noncopyable.h"
+#include "wtf/ThreadingPrimitives.h"
 
 namespace blink {
 class WebThread;
 }
 
 namespace blink {
 
 class TraceLocation;
 
 // The scheduler is an opinionated gateway for arranging work to be run on the
@@ skipping 21 matching lines @@
     // and the caller should yield to let the scheduler service that work.
     // Can be called on the main thread.
     bool shouldYieldForHighPriorityWork();
 
     // The shared timer can be used to schedule a periodic callback which may
     // get preempted by higher priority work.
     void setSharedTimerFiredFunction(void (*function)());
     void setSharedTimerFireInterval(double);
     void stopSharedTimer();
 
+    void runPendingTasks();

[Sami, 2014/08/07 14:24:45]

This one doesn't need to be public, does it?

+
 private:
     Scheduler();
     ~Scheduler();
 
-    void scheduleTask(const TraceLocation&, const Task&);
     void scheduleIdleTask(const IdleTask&);
 
     static void sharedTimerAdapter();
     void tickSharedTimer();
 
     static Scheduler* s_sharedScheduler;
+
+    class TracedTask {
+    public:
+        TracedTask(Task task, TraceLocation location)

[Sami, 2014/08/07 14:24:45]

const Task& and const TraceLocation&

[alexclarke, 2014/08/07 15:15:29]

Done.

+            : m_task(task)
+            , m_location(location) { }
+
+        void run();
+
+    private:
+        Task m_task;
+        TraceLocation m_location;
+    };
+
+    class LockingTracedTaskDeque {
+    public:
+        void append(const TracedTask& value)
+        {
+            Locker<Mutex> lock(m_mutex);
+            m_queue.append(value);
+        }
+
+        bool isEmpty()

[Sami, 2014/08/07 14:24:45]

Could we somehow combine isEmpty() and takeFirst() so that we only take the lock
once?

[alexclarke, 2014/08/07 15:15:29]

Done.

+        {
+            Locker<Mutex> lock(m_mutex);
+            return m_queue.isEmpty();
+        }
+
+        TracedTask takeFirst()
+        {
+            Locker<Mutex> lock(m_mutex);
+            return m_queue.takeFirst();
+        }
+
+    private:
+        WTF::Deque<TracedTask> m_queue;
+        Mutex m_mutex;
+    };
+
+    // These members can be accessed from any thread.
     blink::WebThread* m_mainThread;
+    LockingTracedTaskDeque m_pendingInputTasks;
+    LockingTracedTaskDeque m_pendingCompositorTasks;
+    LockingTracedTaskDeque m_pendingLowPriorityTasks;
+    void (*m_sharedTimerFunction)();

[Sami, 2014/08/07 14:24:45]

This member should only be used on the main thread, right?

 
-    void (*m_sharedTimerFunction)();
+    void maybePostTaskLoopOnMainThread();

[Sami, 2014/08/07 14:24:45]

Could you move these two before the data member declarations?

+    void runHighPriorityTasks();
 };
 
 } // namespace blink
 
 #endif // Scheduler_h