Hangout remote desktop part I - It2Me mode

remoting/webapp/client_screen.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Functions related to the 'client screen' for Chromoting.
  */
 
 'use strict';
@@ skipping 37 matching lines @@
 /**
  * Handle changes in the visibility of the window, for example by pausing video.
  *
  * @return {void} Nothing.
  */
 remoting.onVisibilityChanged = function() {
   if (remoting.clientSession) {
     remoting.clientSession.pauseVideo(
       ('hidden' in document) ? document.hidden : document.webkitHidden);
   }
-}
+};
 
 /**
  * Disconnect the remoting client.
  *
  * @return {void} Nothing.
  */
 remoting.disconnect = function() {
   if (!remoting.clientSession) {
     return;
   }
@@ skipping 13 matching lines @@
  *
  * @param {remoting.ClientSession.StateEvent} state
  */
 function onClientStateChange_(state) {
   switch (state.current) {
     case remoting.ClientSession.State.CLOSED:
       console.log('Connection closed by host');
       if (remoting.clientSession.getMode() ==
           remoting.ClientSession.Mode.IT2ME) {
         remoting.setMode(remoting.AppMode.CLIENT_SESSION_FINISHED_IT2ME);
+        remoting.hrdSessionEvents.raiseEvent(
+            'sessionStateChanged',

[Jamie, 2014/08/05 21:15:13]

Can you declare the available session events as an enum, similar to how it's
done for ClientSession? It would eliminate the possibility of a typo.

Come to think of it, why not just fire sessionStateChanged from ClientSession
directly?

[kelvinp, 2014/08/07 18:03:24]

I can make the event name into a constant.
We can't use clientSession directly as remoting.clientSession does not exist
until the connection is established.  As a result, we would not be able to
detect the connected event and connection failure.

+            remoting.hrdSessionEvents.SessionStates.CLOSED);
       } else {
         remoting.setMode(remoting.AppMode.CLIENT_SESSION_FINISHED_ME2ME);
       }
       break;
 
     case remoting.ClientSession.State.FAILED:
       var error = remoting.clientSession.getError();
       console.error('Client plugin reported connection failed: ' + error);
       if (error == null) {
         error = remoting.Error.UNEXPECTED;
@@ skipping 24 matching lines @@
  */
 function showConnectError_(errorTag) {
   console.error('Connection failed: ' + errorTag);
   var errorDiv = document.getElementById('connect-error-message');
   l10n.localizeElementFromTag(errorDiv, /** @type {string} */ (errorTag));
   remoting.accessCode = '';
   var mode = remoting.clientSession ? remoting.clientSession.getMode()
                                     : remoting.connector.getConnectionMode();
   if (mode == remoting.ClientSession.Mode.IT2ME) {
     remoting.setMode(remoting.AppMode.CLIENT_CONNECT_FAILED_IT2ME);
+    remoting.hrdSessionEvents.raiseEvent(
+      'sessionStateChanged',
+      remoting.hrdSessionEvents.SessionStates.ERROR
+    );
   } else {
     remoting.setMode(remoting.AppMode.CLIENT_CONNECT_FAILED_ME2ME);
   }
 }
 
 /**
  * Set the text on the buttons shown under the error message so that they are
  * easy to understand in the case where a successful connection failed, as
  * opposed to the case where a connection never succeeded.
  */
@@ skipping 164 matching lines @@
 remoting.onConnected = function(clientSession) {
   remoting.clientSession = clientSession;
   remoting.clientSession.addEventListener('stateChanged', onClientStateChange_);
   setConnectionInterruptedButtonsText_();
   document.getElementById('access-code-entry').value = '';
   remoting.setMode(remoting.AppMode.IN_SESSION);
   remoting.toolbar.center();
   remoting.toolbar.preview();
   remoting.clipboard.startSession();
   updateStatistics_();
+  remoting.hrdSessionEvents.raiseEvent(
+    'sessionStateChanged',
+    remoting.hrdSessionEvents.SessionStates.CONNECTED
+  );
   if (remoting.connector.pairingRequested) {
     /**
      * @param {string} clientId
      * @param {string} sharedSecret
      */
     var onPairingComplete = function(clientId, sharedSecret) {
       var pairingInfo = {
         pairingInfo: {
           clientId: clientId,
           sharedSecret: sharedSecret
@@ skipping 37 matching lines @@
  * Create a session connector if one doesn't already exist.
  */
 remoting.ensureSessionConnector_ = function() {
   if (!remoting.connector) {
     remoting.connector = new remoting.SessionConnector(
         document.getElementById('video-container'),
         remoting.onConnected,
         showConnectError_, remoting.onExtensionMessage);
   }
 };