Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 439903002: [Sync] Move reenable logic into DTM (Closed)

Created:
6 years, 4 months ago by Nicolas Zea
Modified:
6 years, 4 months ago
Reviewers:
maniscalco
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

[Sync] Move reenable logic into DTM The DataTypeManager is now in charge of reenabling previously failed types. BUG=368834 R=maniscalco@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291198

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add configure reason #

Patch Set 3 : Rebase #

Patch Set 4 : Fix dcheck #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -23 lines) Patch
M chrome/browser/sync/profile_sync_service.cc View 1 2 1 chunk +2 lines, -15 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/sync_driver/data_type_manager.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/sync_driver/data_type_manager_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/sync_driver/data_type_manager_impl.cc View 1 2 chunks +20 lines, -0 lines 0 comments Download
M components/sync_driver/data_type_manager_impl_unittest.cc View 4 chunks +9 lines, -6 lines 0 comments Download
M components/sync_driver/data_type_manager_mock.h View 1 chunk +1 line, -0 lines 0 comments Download
M sync/engine/get_updates_delegate.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M sync/engine/sync_scheduler_impl.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M sync/internal_api/public/configure_reason.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M sync/internal_api/sync_manager_impl.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M sync/protocol/get_updates_caller_info.proto View 1 1 chunk +2 lines, -0 lines 0 comments Download
M sync/protocol/proto_enum_conversions.cc View 1 4 chunks +4 lines, -2 lines 0 comments Download
M sync/protocol/sync_enums.proto View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 32 (0 generated)
Nicolas Zea
+Nick, PTAL
6 years, 4 months ago (2014-08-04 23:44:18 UTC) #1
maniscalco
Nice, looks simple enough. Just a couple questions... https://codereview.chromium.org/439903002/diff/1/chrome/browser/sync/profile_sync_service.cc File chrome/browser/sync/profile_sync_service.cc (right): https://codereview.chromium.org/439903002/diff/1/chrome/browser/sync/profile_sync_service.cc#newcode953 chrome/browser/sync/profile_sync_service.cc:953: directory_data_type_manager_->ReenableType(type); ...
6 years, 4 months ago (2014-08-04 23:59:30 UTC) #2
Nicolas Zea
PTAL https://codereview.chromium.org/439903002/diff/1/chrome/browser/sync/profile_sync_service.cc File chrome/browser/sync/profile_sync_service.cc (right): https://codereview.chromium.org/439903002/diff/1/chrome/browser/sync/profile_sync_service.cc#newcode953 chrome/browser/sync/profile_sync_service.cc:953: directory_data_type_manager_->ReenableType(type); On 2014/08/04 23:59:30, maniscalco wrote: > I ...
6 years, 4 months ago (2014-08-06 21:20:08 UTC) #3
maniscalco
lgtm
6 years, 4 months ago (2014-08-06 21:26:20 UTC) #4
Nicolas Zea
The CQ bit was checked by zea@chromium.org
6 years, 4 months ago (2014-08-06 21:32:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/439903002/20001
6 years, 4 months ago (2014-08-06 21:34:03 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-06 23:13:53 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-06 23:17:24 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/49025) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/38269) win_gpu ...
6 years, 4 months ago (2014-08-06 23:17:25 UTC) #9
Nicolas Zea
The CQ bit was checked by zea@chromium.org
6 years, 4 months ago (2014-08-08 23:19:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/439903002/20001
6 years, 4 months ago (2014-08-08 23:21:54 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-09 05:12:28 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-09 05:49:55 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/2564) linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/4603) mac_chromium_rel_swarming ...
6 years, 4 months ago (2014-08-09 05:49:56 UTC) #14
Nicolas Zea
The CQ bit was checked by zea@chromium.org
6 years, 4 months ago (2014-08-11 17:06:17 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/439903002/20001
6 years, 4 months ago (2014-08-11 17:08:15 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-12 04:16:09 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 04:52:59 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/3172)
6 years, 4 months ago (2014-08-12 04:53:00 UTC) #19
Nicolas Zea
The CQ bit was checked by zea@chromium.org
6 years, 4 months ago (2014-08-20 17:52:56 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/439903002/40001
6 years, 4 months ago (2014-08-20 17:53:33 UTC) #21
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-20 19:40:12 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-20 20:12:02 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/5232)
6 years, 4 months ago (2014-08-20 20:12:03 UTC) #24
Nicolas Zea
The CQ bit was checked by zea@chromium.org
6 years, 4 months ago (2014-08-20 20:12:36 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/439903002/60001
6 years, 4 months ago (2014-08-20 20:14:27 UTC) #26
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-20 22:42:16 UTC) #27
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-20 22:47:19 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/55199) android_clang_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg/builds/7980)
6 years, 4 months ago (2014-08-20 22:47:20 UTC) #29
Nicolas Zea
The CQ bit was checked by zea@chromium.org
6 years, 4 months ago (2014-08-21 20:40:00 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/439903002/60001
6 years, 4 months ago (2014-08-21 20:40:43 UTC) #31
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 21:40:02 UTC) #32
Message was sent while issue was closed. 
Committed patchset #4 (60001) as 291198

Powered by Google App Engine
This is Rietveld 408576698