Initial import of unittests using GTest/GMock.

Initial import of unittests using GTest/GMock.

R=jochen@chromium.org, svenpanne@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=22847

[Benedikt Meurer, 2014-08-05 07:06:44]

PTAL

[Sven Panne, 2014-08-05 07:20:16]

lgtm

https://codereview.chromium.org/439863004/diff/1/tools/presubmit.py
File tools/presubmit.py (right):

https://codereview.chromium.org/439863004/diff/1/tools/presubmit.py#newcode239
tools/presubmit.py:239: return ['src', 'include', 'samples', join('test',
'cctest'), join('test', 'unittests')]
80 columns

[jochen (gone - plz use gerrit), 2014-08-05 07:36:20]

why not put the unitttests next to the actually tested files?

And name them foo_unittests.cc

https://codereview.chromium.org/439863004/diff/20001/test/unittests/test-isol...
File test/unittests/test-isolate.h (right):

https://codereview.chromium.org/439863004/diff/20001/test/unittests/test-isol...
test/unittests/test-isolate.h:20: ~IsolateTest();
i bet that needs to be virtual (and all other tests)

https://codereview.chromium.org/439863004/diff/20001/test/unittests/test-isol...
test/unittests/test-isolate.h:27: };
DISALLOW_COPY_AND_ASSIGN()....

https://codereview.chromium.org/439863004/diff/20001/test/unittests/unittests.cc
File test/unittests/unittests.cc (right):

https://codereview.chromium.org/439863004/diff/20001/test/unittests/unittests...
test/unittests/unittests.cc:19: if (v8::V8::Initialize()) {
consider doing less here as unit tests for base or libplatform won't need any of
this. on the other hand it looks confusing as you don't set up ICU which a
regular embedder would have to

https://codereview.chromium.org/439863004/diff/20001/test/unittests/unittests...
File test/unittests/unittests.gyp (right):

https://codereview.chromium.org/439863004/diff/20001/test/unittests/unittests...
test/unittests/unittests.gyp:20: 'compiler/compiler.h',
it's a bit odd that this file doesn't have a test prefix while the others do

[Benedikt Meurer, 2014-08-05 08:01:53]

https://codereview.chromium.org/439863004/diff/20001/test/unittests/test-isol...
File test/unittests/test-isolate.h (right):

https://codereview.chromium.org/439863004/diff/20001/test/unittests/test-isol...
test/unittests/test-isolate.h:20: ~IsolateTest();
On 2014/08/05 07:36:19, jochen wrote:
> i bet that needs to be virtual (and all other tests)

Done.

https://codereview.chromium.org/439863004/diff/20001/test/unittests/test-isol...
test/unittests/test-isolate.h:27: };
On 2014/08/05 07:36:19, jochen wrote:
> DISALLOW_COPY_AND_ASSIGN()....

Done.

https://codereview.chromium.org/439863004/diff/20001/test/unittests/unittests.cc
File test/unittests/unittests.cc (right):

https://codereview.chromium.org/439863004/diff/20001/test/unittests/unittests...
test/unittests/unittests.cc:19: if (v8::V8::Initialize()) {
On 2014/08/05 07:36:19, jochen wrote:
> consider doing less here as unit tests for base or libplatform won't need any
of
> this. on the other hand it looks confusing as you don't set up ICU which a
> regular embedder would have to

Done.

https://codereview.chromium.org/439863004/diff/20001/test/unittests/unittests...
File test/unittests/unittests.gyp (right):

https://codereview.chromium.org/439863004/diff/20001/test/unittests/unittests...
test/unittests/unittests.gyp:20: 'compiler/compiler.h',
On 2014/08/05 07:36:19, jochen wrote:
> it's a bit odd that this file doesn't have a test prefix while the others do

Done.

[Benedikt Meurer, 2014-08-05 08:06:03]

https://codereview.chromium.org/439863004/diff/1/tools/presubmit.py
File tools/presubmit.py (right):

https://codereview.chromium.org/439863004/diff/1/tools/presubmit.py#newcode239
tools/presubmit.py:239: return ['src', 'include', 'samples', join('test',
'cctest'), join('test', 'unittests')]
On 2014/08/05 07:20:16, Sven Panne wrote:
> 80 columns

Done.

[jochen (gone - plz use gerrit), 2014-08-05 08:07:00]

lgtm

[Benedikt Meurer, 2014-08-05 08:07:37]

Committed patchset #3 manually as 22847 (presubmit successful).