Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: media/cast/sender/video_sender_unittest.cc

Issue 439863003: Cast: Use fixed bitrate and set it once for hardware encoder (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/cast/sender/video_sender.cc ('k') | media/cast/test/fake_video_encode_accelerator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cast/sender/video_sender_unittest.cc
diff --git a/media/cast/sender/video_sender_unittest.cc b/media/cast/sender/video_sender_unittest.cc
index 38dfa518f8d0913e34ae63553e2c0b110e62519f..06e9dc0678f4edfde64968e809ecc0fdadbb7f56 100644
--- a/media/cast/sender/video_sender_unittest.cc
+++ b/media/cast/sender/video_sender_unittest.cc
@@ -174,7 +174,8 @@ class VideoSenderTest : public ::testing::Test {
if (external) {
scoped_ptr<VideoEncodeAccelerator> fake_vea(
- new test::FakeVideoEncodeAccelerator(task_runner_));
+ new test::FakeVideoEncodeAccelerator(task_runner_,
+ &stored_bitrates_));
video_sender_.reset(
new PeerVideoSender(cast_environment_,
video_config,
@@ -221,6 +222,7 @@ class VideoSenderTest : public ::testing::Test {
scoped_ptr<CastTransportSenderImpl> transport_sender_;
scoped_refptr<test::FakeSingleThreadTaskRunner> task_runner_;
scoped_ptr<PeerVideoSender> video_sender_;
+ std::vector<uint32> stored_bitrates_;
scoped_refptr<CastEnvironment> cast_environment_;
int last_pixel_value_;
@@ -247,8 +249,15 @@ TEST_F(VideoSenderTest, ExternalEncoder) {
const base::TimeTicks capture_time = testing_clock_->NowTicks();
video_sender_->InsertRawVideoFrame(video_frame, capture_time);
-
task_runner_->RunTasks();
+ video_sender_->InsertRawVideoFrame(video_frame, capture_time);
+ task_runner_->RunTasks();
+ video_sender_->InsertRawVideoFrame(video_frame, capture_time);
+ task_runner_->RunTasks();
+
+ // Fixed bitrate is used for external encoder. Bitrate is only once
+ // to the encoder.
+ EXPECT_EQ(1u, stored_bitrates_.size());
// We need to run the task to cleanup the GPU instance.
video_sender_.reset(NULL);
« no previous file with comments | « media/cast/sender/video_sender.cc ('k') | media/cast/test/fake_video_encode_accelerator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698