Cast: Use fixed bitrate and set it once for hardware encoder

media/cast/test/fake_video_encode_accelerator.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/cast/test/fake_video_encode_accelerator.h"
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "base/logging.h"
 #include "base/single_thread_task_runner.h"
 
 namespace media {
 namespace cast {
 namespace test {
 
 static const unsigned int kMinimumInputCount = 1;
 static const size_t kMinimumOutputBufferSize = 123456;
 
 FakeVideoEncodeAccelerator::FakeVideoEncodeAccelerator(
-    const scoped_refptr<base::SingleThreadTaskRunner>& task_runner)
+    const scoped_refptr<base::SingleThreadTaskRunner>& task_runner,
+    std::vector<uint32>* stored_bitrates)
     : task_runner_(task_runner),
+      stored_bitrates_(stored_bitrates),

[miu, 2014/08/05 21:52:07]

For safety, DCHECK(stored_bitrates_), since it is assumed not to be NULL. 
Alternatively, do null checking in RequestEncodingParametersChange().

[Alpha Left Google, 2014/08/06 01:24:54]

Done.

       client_(NULL),
       first_(true),
       weak_this_factory_(this) {}
 
 FakeVideoEncodeAccelerator::~FakeVideoEncodeAccelerator() {
   weak_this_factory_.InvalidateWeakPtrs();
 }
 
 bool FakeVideoEncodeAccelerator::Initialize(
     media::VideoFrame::Format input_format,
@@ skipping 41 matching lines @@
 }
 
 void FakeVideoEncodeAccelerator::UseOutputBitstreamBuffer(
     const BitstreamBuffer& buffer) {
   available_buffer_ids_.push_back(buffer.id());
 }
 
 void FakeVideoEncodeAccelerator::RequestEncodingParametersChange(
     uint32 bitrate,
     uint32 framerate) {
-  // No-op.
+  stored_bitrates_->push_back(bitrate);
 }
 
 void FakeVideoEncodeAccelerator::Destroy() { delete this; }
 
 void FakeVideoEncodeAccelerator::SendDummyFrameForTesting(bool key_frame) {
   DoBitstreamBufferReady(0, 23, key_frame);
 }
 
 void FakeVideoEncodeAccelerator::DoRequireBitstreamBuffers(
     unsigned int input_count,
     const gfx::Size& input_coded_size,
     size_t output_buffer_size) const {
   client_->RequireBitstreamBuffers(
       input_count, input_coded_size, output_buffer_size);
 }
 
 void FakeVideoEncodeAccelerator::DoBitstreamBufferReady(
     int32 bitstream_buffer_id,
     size_t payload_size,
     bool key_frame) const {
   client_->BitstreamBufferReady(bitstream_buffer_id, payload_size, key_frame);
 }
 
 }  // namespace test
 }  // namespace cast
 }  // namespace media