src/gpu/effects/GrBicubicEffect.cpp - Issue 439853002: Replace op== with CombineIfPossible in GrDrawState.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/effects/GrBicubicEffect.cpp

Issue 439853002: Replace op== with CombineIfPossible in GrDrawState. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/effects/GrBicubicEffect.cpp

diff --git a/src/gpu/effects/GrBicubicEffect.cpp b/src/gpu/effects/GrBicubicEffect.cpp

index cc621ddec2aef57ecc24e13c71a675ccc12adcc2..fb98b4ac4ce03050e745782c65d144fcfd985c7d 100644

--- a/src/gpu/effects/GrBicubicEffect.cpp

+++ b/src/gpu/effects/GrBicubicEffect.cpp

@@ -164,7 +164,8 @@ const GrBackendEffectFactory& GrBicubicEffect::getFactory() const {

bool GrBicubicEffect::onIsEqual(const GrEffect& sBase) const {

const GrBicubicEffect& s = CastEffect<GrBicubicEffect>(sBase);

return this->textureAccess(0) == s.textureAccess(0) &&

- !memcmp(fCoefficients, s.coefficients(), 16);

+ !memcmp(fCoefficients, s.coefficients(), 16) &&

+ fDomain == s.fDomain;

bsalomon 2014/08/04 19:52:33 uncovered this bug while working on this CL.

}

void GrBicubicEffect::getConstantColorComponents(GrColor* color, uint32_t* validFlags) const {

« src/gpu/GrInOrderDrawBuffer.h ('K') | « src/gpu/GrInOrderDrawBuffer.cpp ('k') | no next file » | no next file with comments »