Issue 439853002: Replace op== with CombineIfPossible in GrDrawState.

Issue 439853002: Replace op== with CombineIfPossible in GrDrawState. (Closed)

Created:
6 years, 4 months ago by bsalomon

Modified:
6 years, 4 months ago

Reviewers:
egdaniel, robertphillips

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Replace op== with CombineIfPossible in GrDrawState. Committed: https://skia.googlesource.com/skia/+/838f62db0a77487f6732ed13a0972a1e646ae16a

Patch Set 2 : Address comments #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -51 lines)			Patch
M	src/gpu/GrDrawState.h	View	1	1 chunk	+43 lines, -28 lines	0 comments	Download
M	src/gpu/GrInOrderDrawBuffer.h	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/gpu/GrInOrderDrawBuffer.cpp	View		6 chunks	+24 lines, -19 lines	0 comments	Download
M	src/gpu/effects/GrBicubicEffect.cpp	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

bsalomon

https://codereview.chromium.org/439853002/diff/1/src/gpu/effects/GrBicubicEffect.cpp File src/gpu/effects/GrBicubicEffect.cpp (right): https://codereview.chromium.org/439853002/diff/1/src/gpu/effects/GrBicubicEffect.cpp#newcode168 src/gpu/effects/GrBicubicEffect.cpp:168: fDomain == s.fDomain; uncovered this bug while working on ...

6 years, 4 months ago (2014-08-04 19:52:33 UTC) #1

egdaniel

lgtm with small comment comment. Also assuming your bug fix is correct https://codereview.chromium.org/439853002/diff/1/src/gpu/GrInOrderDrawBuffer.h File src/gpu/GrInOrderDrawBuffer.h ...

6 years, 4 months ago (2014-08-04 20:12:42 UTC) #2

robertphillips

lgtm + nits https://codereview.chromium.org/439853002/diff/1/src/gpu/GrDrawState.h File src/gpu/GrDrawState.h (right): https://codereview.chromium.org/439853002/diff/1/src/gpu/GrDrawState.h#newcode890 src/gpu/GrDrawState.h:890: This function https://codereview.chromium.org/439853002/diff/1/src/gpu/GrDrawState.h#newcode892 src/gpu/GrDrawState.h:892: a single ...

6 years, 4 months ago (2014-08-04 21:48:33 UTC) #3

bsalomon

https://codereview.chromium.org/439853002/diff/1/src/gpu/GrDrawState.h File src/gpu/GrDrawState.h (right): https://codereview.chromium.org/439853002/diff/1/src/gpu/GrDrawState.h#newcode890 src/gpu/GrDrawState.h:890: On 2014/08/04 21:48:32, robertphillips wrote: > This function Done. ...

6 years, 4 months ago (2014-08-05 14:04:30 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/439853002/20001

6 years, 4 months ago (2014-08-05 14:05:35 UTC) #6

commit-bot: I haz the power

6 years, 4 months ago (2014-08-05 14:16:03 UTC) #7

Message was sent while issue was closed.

Change committed as 838f62db0a77487f6732ed13a0972a1e646ae16a

Expand Messages | Collapse Messages