Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 439843002: Merge 280354 "Have the Debugger extension api check that it has ..." (Closed)

Created:
6 years, 4 months ago by not at google - send to devlin
Modified:
6 years, 4 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Merge 280354 "Have the Debugger extension api check that it has ..." > Have the Debugger extension api check that it has access to the tab > > Check PermissionsData::CanAccessTab() prior to attaching the debugger. > > BUG=367567 > > Review URL: https://codereview.chromium.org/352523003 TBR=rdevlin.cronin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287394

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+310 lines, -39 lines) Patch
M chrome/browser/extensions/api/debugger/debugger_api.cc View 5 chunks +20 lines, -10 lines 0 comments Download
M chrome/browser/extensions/api/debugger/debugger_api_constants.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/debugger/debugger_api_constants.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/debugger/debugger_apitest.cc View 1 chunk +134 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/debugger/debugger_extension_apitest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/debugger/background.js View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/permissions/permissions_data.h View 1 chunk +8 lines, -0 lines 0 comments Download
M extensions/common/permissions/permissions_data.cc View 3 chunks +44 lines, -23 lines 0 comments Download
M extensions/common/permissions/permissions_data_unittest.cc View 3 chunks +89 lines, -2 lines 0 comments Download
M extensions/common/url_pattern.h View 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/common/url_pattern.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
not at google - send to devlin
6 years, 4 months ago (2014-08-04 19:39:32 UTC) #1
not at google - send to devlin
6 years, 4 months ago (2014-08-04 19:39:58 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r287394 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698