Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(882)

Issue 439753002: Files.app: Add the MockDirectoryEntry class. (Closed)

Created:
6 years, 4 months ago by hirono
Modified:
6 years, 4 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, yoshiki+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Files.app: Add the MockDirectoryEntry class. BUG=315439 TEST=run the js tests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287496

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -27 lines) Patch
M chrome/test/data/file_manager/unit_tests/metadata_cache_unittest.html View 1 chunk +1 line, -1 line 0 comments Download
A chrome/test/data/file_manager/unit_tests/mocks/mock_entry.js View 1 1 chunk +73 lines, -0 lines 0 comments Download
D chrome/test/data/file_manager/unit_tests/mocks/mock_file_entry.js View 1 chunk +0 lines, -24 lines 0 comments Download
M chrome/test/data/file_manager/unit_tests/navigation_list_model_unittest.html View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
hirono
PTAL the CL? The mock is going to be used by JS test of FileOperationManager.
6 years, 4 months ago (2014-08-04 09:42:42 UTC) #1
yoshiki
lgtm https://codereview.chromium.org/439753002/diff/20001/chrome/test/data/file_manager/unit_tests/mocks/mock_entry.js File chrome/test/data/file_manager/unit_tests/mocks/mock_entry.js (right): https://codereview.chromium.org/439753002/diff/20001/chrome/test/data/file_manager/unit_tests/mocks/mock_entry.js#newcode30 chrome/test/data/file_manager/unit_tests/mocks/mock_entry.js:30: * @param {string} fullPath Full path for the ...
6 years, 4 months ago (2014-08-04 16:35:52 UTC) #2
hirono
Thank you! https://codereview.chromium.org/439753002/diff/20001/chrome/test/data/file_manager/unit_tests/mocks/mock_entry.js File chrome/test/data/file_manager/unit_tests/mocks/mock_entry.js (right): https://codereview.chromium.org/439753002/diff/20001/chrome/test/data/file_manager/unit_tests/mocks/mock_entry.js#newcode30 chrome/test/data/file_manager/unit_tests/mocks/mock_entry.js:30: * @param {string} fullPath Full path for ...
6 years, 4 months ago (2014-08-05 01:44:39 UTC) #3
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 4 months ago (2014-08-05 01:44:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/439753002/40001
6 years, 4 months ago (2014-08-05 01:45:49 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-05 04:21:08 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 04:25:48 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/builds/2967)
6 years, 4 months ago (2014-08-05 04:25:49 UTC) #8
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 4 months ago (2014-08-05 04:36:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/439753002/40001
6 years, 4 months ago (2014-08-05 04:38:03 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium.mac ...
6 years, 4 months ago (2014-08-05 05:30:55 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 05:39:09 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/builds/2984)
6 years, 4 months ago (2014-08-05 05:39:10 UTC) #13
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 4 months ago (2014-08-05 06:19:37 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/439753002/40001
6 years, 4 months ago (2014-08-05 06:20:15 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium.mac ...
6 years, 4 months ago (2014-08-05 06:33:17 UTC) #16
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 08:20:46 UTC) #17
Message was sent while issue was closed.
Change committed as 287496

Powered by Google App Engine
This is Rietveld 408576698