Source/core/html/HTMLMediaElement.cpp - Issue 439723003: Prevent GC of media elements that are delaying the load event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLMediaElement.cpp

Issue 439723003: Prevent GC of media elements that are delaying the load event (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLMediaElement.cpp

diff --git a/Source/core/html/HTMLMediaElement.cpp b/Source/core/html/HTMLMediaElement.cpp

index 86ec6ffd1cbf01b7fa3a9448b3b356fe1b01e574..bba6aa332b5a23c199964d1877bbf0a3af6d3e66 100644

--- a/Source/core/html/HTMLMediaElement.cpp

+++ b/Source/core/html/HTMLMediaElement.cpp

@@ -3469,7 +3469,7 @@ void HTMLMediaElement::stop()

bool HTMLMediaElement::hasPendingActivity() const

{

- return (hasAudio() && isPlaying()) || m_asyncEventQueue->hasPendingEvents();

+ return m_shouldDelayLoadEvent || (hasAudio() && isPlaying()) || m_asyncEventQueue->hasPendingEvents();

}

void HTMLMediaElement::contextDestroyed()

« no previous file with comments | « LayoutTests/media/gc-during-load-expected.txt ('k') | no next file » | no next file with comments »