DevTools: Implement async stacks for IndexedDB.

DevTools: Implement async stacks for IndexedDB.

BUG=390865, 272416
R=yurys

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179754

[jsbell, 2014-08-04 16:42:04]

On 2014/08/04 16:15:10, aandrey wrote:

Onbl

[jsbell, 2014-08-04 16:44:42]

blocked and upgradeneeded are not final states - they should be followed by
subsequent calls on the same object (success or error). Is that accounted for?

[aandrey, 2014-08-04 17:01:37]

On 2014/08/04 16:44:42, jsbell (OOO through Aug 10) wrote:
> blocked and upgradeneeded are not final states - they should be followed by
> subsequent calls on the same object (success or error). Is that accounted for?

Yep (you can check the test).
The async call stack for operation gets deleted in ~WebIDBCallbacksImpl()

[aandrey, 2014-08-06 16:34:10]

ping?

[yurys, 2014-08-07 08:45:06]

lgtm

[aandrey, 2014-08-07 10:03:08]

The CQ bit was checked by aandrey@chromium.org

[commit-bot: I haz the power, 2014-08-07 10:04:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aandrey@chromium.org/439713009/1

[commit-bot: I haz the power, 2014-08-07 11:21:27]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/2...)
  win_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/bu...)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/21534)

[commit-bot: I haz the power, 2014-08-07 11:23:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-07 11:23:59]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)

[aandrey, 2014-08-07 11:44:31]

need an owner stamp on indexeddb/

[cmumford, 2014-08-07 15:11:24]

Non owner review questions.

https://codereview.chromium.org/439713009/diff/1/Source/modules/indexeddb/Web...
File Source/modules/indexeddb/WebIDBCallbacksImpl.cpp (right):

https://codereview.chromium.org/439713009/diff/1/Source/modules/indexeddb/Web...
Source/modules/indexeddb/WebIDBCallbacksImpl.cpp:66: m_asyncOperationId =
InspectorInstrumentation::traceAsyncOperationStarting(m_request->executionContext(),
"IndexedDB");
Elsewhere (like in FileSystemCallbacks.cpp) a check for a NULL execution context
is made. Is this a case (like during shutdown) that needs to be checked for?

https://codereview.chromium.org/439713009/diff/1/Source/modules/indexeddb/Web...
Source/modules/indexeddb/WebIDBCallbacksImpl.cpp:71:
InspectorInstrumentation::traceAsyncOperationCompleted(m_request->executionContext(),
m_asyncOperationId);
Same NULL ptr check question as constructor.

[aandrey, 2014-08-07 15:35:40]

https://codereview.chromium.org/439713009/diff/1/Source/modules/indexeddb/Web...
File Source/modules/indexeddb/WebIDBCallbacksImpl.cpp (right):

https://codereview.chromium.org/439713009/diff/1/Source/modules/indexeddb/Web...
Source/modules/indexeddb/WebIDBCallbacksImpl.cpp:66: m_asyncOperationId =
InspectorInstrumentation::traceAsyncOperationStarting(m_request->executionContext(),
"IndexedDB");
On 2014/08/07 15:11:24, cmumford wrote:
> Elsewhere (like in FileSystemCallbacks.cpp) a check for a NULL execution
context
> is made. Is this a case (like during shutdown) that needs to be checked for?

Not necessary, the NULL check is done at
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

[cmumford, 2014-08-07 15:38:00]

non owner lgtm

[dgrogan, 2014-08-07 19:31:22]

lgtm

[aandrey, 2014-08-07 20:52:29]

The CQ bit was checked by aandrey@chromium.org

[commit-bot: I haz the power, 2014-08-07 20:52:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aandrey@chromium.org/439713009/1

[commit-bot: I haz the power, 2014-08-07 21:11:16]

Change committed as 179754