Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 439713003: Drop prefixes from test data resource IDs (Closed)

Created:
6 years, 4 months ago by hashimoto
Modified:
6 years, 4 months ago
Reviewers:
kinaba
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, nkostylev+watch_chromium.org, hashimoto+watch_chromium.org, tzik, tfarina, haitaol+watch_chromium.org, nhiroki, oshima+watch_chromium.org, stevenjb+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org, maniscalco+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Drop prefixes from test data resource IDs These prefixes were only available in IDs aquired with the old API. BUG=None TEST=git cl try Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287322

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -190 lines) Patch
M chrome/browser/chromeos/drive/change_list_processor_unittest.cc View 11 chunks +33 lines, -33 lines 0 comments Download
M chrome/browser/chromeos/drive/fake_file_system_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_cache_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/copy_operation_unittest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/drive/job_scheduler_unittest.cc View 19 chunks +25 lines, -25 lines 0 comments Download
M chrome/browser/chromeos/drive/resource_metadata_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/sync/entry_update_performer_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/drive/fake_drive_service_unittest.cc View 57 chunks +96 lines, -96 lines 0 comments Download
M chrome/browser/drive/test_util.cc View 15 chunks +20 lines, -20 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hashimoto
6 years, 4 months ago (2014-08-04 08:16:57 UTC) #1
kinaba
lgtm
6 years, 4 months ago (2014-08-04 08:25:50 UTC) #2
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 4 months ago (2014-08-04 08:34:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/439713003/20001
6 years, 4 months ago (2014-08-04 08:35:10 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-04 11:49:27 UTC) #5
Message was sent while issue was closed.
Change committed as 287322

Powered by Google App Engine
This is Rietveld 408576698